Move BooleanBufferBuilder and NullBufferBuilder to arrow_buffer #4338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Jun 1, 2023
| @@ -128,10 +127,15 @@ impl NullBufferBuilder { | |||
|
|
|||
| /// Builds the null buffer and resets the builder. | |||
| /// Returns `None` if the builder only contains `true`s. | |||
| pub fn finish(&mut self) -> Option<Buffer> { | |||
| let buf = self.bitmap_builder.take().map(Into::into); | |||
| pub fn finish(&mut self) -> Option<NullBuffer> { | |||
There was a problem hiding this comment.
As this was previously crate-private I took the opportunity to change the signature before it becomes public and changing would be a breaking change
viirya
approved these changes
Jun 1, 2023
|
I don't see api change except for moving the two builders, is it right? |
|
I removed the deprecated combine_option_bitmap as part of the move (as it depended on ArrayData) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Manually creating a NullBuffer is cumbersome, moving the builders into arrow_buffer will allow defining more ergonomic constructors for these types
What changes are included in this PR?
Are there any user-facing changes?
It removes the deprecated combine_option_bitmap