Faster unpacking of Int32Type dictionary #4406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Jun 13, 2023
| take(cast_dict_values.as_ref(), u32_indices, None) | ||
| let keys = dict_array.keys(); | ||
| match K::DATA_TYPE { | ||
| DataType::Int32 => { |
There was a problem hiding this comment.
Theoretically we could pass the keys directly to take, this approach avoids additional codegen, and also appears to be faster for reasons I don't understand 😅
crepererum
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
There is no need to perform a checked conversion for Int32Type dictionary keys to UInt32Type
What changes are included in this PR?
Are there any user-facing changes?