Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add strict mode to json reader #4421

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

blinkseb
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

Hello,

This PR adds a new strict mode for the json reader. If strict mode is enabled, the parser will return an error if it encounters a column not present in the schema. It's useful for example if you want to ensure that your schema match 100% the JSON file.

The strict mode is added as a new option of ReaderBuilder.

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jun 16, 2023
@blinkseb blinkseb force-pushed the feat-json-strict-mode branch 2 times, most recently from a82774e to d72a87d Compare June 16, 2023 19:43
When strict mode is enabled, the parser will return an error if it
encounters a column not present in the schema
@blinkseb blinkseb force-pushed the feat-json-strict-mode branch from d72a87d to 16d5610 Compare June 16, 2023 19:43
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good to me

@tustvold tustvold merged commit c41dc7f into apache:master Jun 20, 2023
@blinkseb blinkseb deleted the feat-json-strict-mode branch June 23, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants