unify substring for binary&utf8 #4442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackwener
force-pushed
the
unify
branch
2 times, most recently
from
7c0c8ab to
a89686a
Compare
alamb
reviewed
Jun 22, 2023
There was a problem hiding this comment.
Thank you @jackwener -- the idea here is great and reducing code is 💯
My only concern is about utf8 boundary checking
maybe @tustvold has some thoughts
jackwener
force-pushed
the
unify
branch
5 times, most recently
from
3f0a1cc to
34615bb
Compare
Thanks for @alamb review, I have added code to check just when array is StringArray/LargeStringArray |
alamb
approved these changes
Jun 23, 2023
| @@ -1020,4 +968,17 @@ mod tests { | |||
| let err = substring(&array, 0, Some(5)).unwrap_err().to_string(); | |||
| assert!(err.contains("invalid utf-8 boundary")); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn non_utf8_bytes() { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
After arrow-rs have
GenericByteArray, we can unifysubstringofbinary&utf8.Are there any user-facing changes?