feat(flight-sql): Allow implementations of FlightSqlService to handle custom actions and commands #4463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… custom actions and commands
github-actions
bot
added
arrow
alamb
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4439.
Rationale for this change
Allows implementations of
FlightSqlServiceto implement custom actions and commands (DoPut, DoExchange). Capability already exists for DoGet.What changes are included in this PR?
Added the methods
do_put_fallback,do_action_fallbackanddo_exchange_fallbackto the traitFlightSqlService, and corresponding use inimpl<T: FlightSqlService + Send + 'static> FlightService for Tfollowing the same pattern that already existed fordo_get/do_get_fallback. Added a methodlist_custom_actionsto allow implementations of the traitFlightSqlServiceto supply additional custom actions to the result oflist_actionsinimpl<T: FlightSqlService + Send + 'static> FlightService for T.Are there any user-facing changes?
Yes, extended the API surface of the trait
FlightSqlService.