IPC writer truncated sliced list/map values #5071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
approved these changes
Nov 13, 2023
| @@ -1139,6 +1139,29 @@ fn get_buffer_element_width(spec: &BufferSpec) -> usize { | |||
| } | |||
| } | |||
|
|
|||
| /// Common functionality for re-encoding offsets. Returns the new offsets as well as | |||
| /// original start offset and length for use in slicing child data. | |||
| fn reencode_offsets<O: OffsetSizeTrait>( | |||
Ah my mistake, reverted |
|
Thanks once again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4409
Rationale for this change
Serialize only the necessary child data values for ListArray/LargeListArray/MapArray
What changes are included in this PR?
Apply similar truncating logic for Binary/Utf8 to List/LargeList/Map when doing IPC write, but ensure we apply the truncation to their child array instead of values buffer (as done for Binary/Utf8)
Are there any user-facing changes?