Support StringArray creation from String Vec
#522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jul 6, 2021
silathdiir
force-pushed
the
allow-string-array-creation-from-string-vec
branch
from
69d2919 to
f7437b9
Compare
paddyhoran
approved these changes
Jul 9, 2021
|
Thanks again @silathdiir ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #519.
Rationale for this change
As described in the issue, tries to create a
StringArrayfrom aVec<String>.What changes are included in this PR?
from_vecto support generic parameter type ofAsRef<str>.From<Vec<String>>Implementation forStringArray.Are there any user-facing changes?
With this fix,
StringArraycould be created fromVec<String>.