Remove undefined behavior in value method of boolean and primitive arrays
#644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dandandan
commented
Jul 31, 2021
| @@ -100,7 +100,7 @@ impl BooleanArray { | |||
| /// | |||
| /// Note this doesn't do any bound checking, for performance reason. | |||
| pub fn value(&self, i: usize) -> bool { | |||
| debug_assert!(i < self.len()); | |||
Dandandan
commented
Jul 31, 2021
| #[inline] | ||
| pub fn value(&self, i: usize) -> T::Native { | ||
| debug_assert!(i < self.len()); |
Dandandan
commented
Jul 31, 2021
| pub fn value(&self, i: usize) -> &str { | ||
| assert!(i < self.data.len(), "StringArray out of bounds access"); | ||
| //Soundness: length checked above, offset buffer length is 1 larger than logical array length |
Dandandan
commented
Jul 31, 2021
| let comparison = (0..$left.len()).map(|i| $op($left.value(i), $right.value(i))); | ||
| // Safety: | ||
| // `i < $left.len()` and $left.len() == $right.len() | ||
| let comparison = (0..$left.len()) |
There was a problem hiding this comment.
Avoid perf. penalty by using unsafe version here
Dandandan
commented
Jul 31, 2021
| @@ -121,8 +124,10 @@ macro_rules! compare_op_primitive { | |||
| macro_rules! compare_op_scalar { | |||
| ($left: expr, $right:expr, $op:expr) => {{ | |||
| let null_bit_buffer = $left.data().null_buffer().cloned(); | |||
|
|
|||
| let comparison = (0..$left.len()).map(|i| $op($left.value(i), $right)); | |||
| // Safety: | |||
There was a problem hiding this comment.
Avoid perf. penalty by using unsafe version here
Dandandan
changed the title
value methodvalue method of boolean and primitive arrays
Codecov Report
@@ Coverage Diff @@
## master #644 +/- ##
==========================================
+ Coverage 82.48% 82.51% +0.02%
==========================================
Files 167 168 +1
Lines 46450 47227 +777
==========================================
+ Hits 38315 38968 +653
- Misses 8135 8259 +124
Continue to review full report at Codecov.
|
paddyhoran
approved these changes
Aug 2, 2021
alamb
approved these changes
Aug 2, 2021
There was a problem hiding this comment.
Seems like a nice cleanup to me. @jorgecarleitao would you like to review this PR as well?
jorgecarleitao
approved these changes
Aug 3, 2021
nevi-me
approved these changes
Aug 3, 2021
alamb
pushed a commit
that referenced
this pull request
Aug 5, 2021
…arrays (#644) * Remove UB in `value` * Add safety note
alamb
added a commit
that referenced
this pull request
Aug 8, 2021
…arrays (#644) (#668) * Remove UB in `value` * Add safety note Co-authored-by: Daniël Heres <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #645
Rationale for this change
The value methods only had
debug_assert!in them, which made that the check is removed in release mode.What changes are included in this PR?
Are there any user-facing changes?