Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick Write FixedLenByteArray stats for FixedLenByteArray columns (not ByteArray stats) to active_release #683

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Aug 10, 2021

Automatic cherry-pick of fa5acd9

@alamb alamb force-pushed the cherry_pick_fa5acd97 branch from 8b8809f to e7e93bf Compare August 12, 2021 18:54
@alamb
Copy link
Contributor Author

alamb commented Aug 12, 2021

rebased

@github-actions github-actions bot added the parquet Changes to the parquet crate label Aug 12, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #683 (e7e93bf) into active_release (72f2407) will increase coverage by 0.00%.
The diff coverage is 73.68%.

Impacted file tree graph

@@               Coverage Diff               @@
##           active_release     #683   +/-   ##
===============================================
  Coverage           82.39%   82.39%           
===============================================
  Files                 167      167           
  Lines               46554    46568   +14     
===============================================
+ Hits                38360    38372   +12     
- Misses               8194     8196    +2     
Impacted Files Coverage Δ
parquet/src/column/writer.rs 92.81% <73.68%> (-0.22%) ⬇️
parquet/src/encodings/encoding.rs 94.67% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72f2407...e7e93bf. Read the comment docs.

@alamb alamb merged commit 6a96f5f into active_release Aug 12, 2021
@alamb alamb deleted the cherry_pick_fa5acd97 branch August 12, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants