Switch to use u64 range instead of usize, for better wasm32 support #6961
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
usize
withu64
#5351Rationale for this change
Ranges should be u64 so that 32 bit platforms can read files larger than 4GB. More details can be found in #5351
What changes are included in this PR?
This is a rather simple change. No functionality change for 64 bit platforms. But is a breaking change for trait implementors.
Given that we already break one in #6619, it's seems like a good timing to also include this change.
This PR added and removed a few casting. I have checked the casting is ok, but please help me check again.
My principle of using
usize
vsu64
:usize
, e.g., slicing a memory rangeu64
Are there any user-facing changes?