Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[53.0.0_maintenance] Fix CI #6964

Open
wants to merge 3 commits into
base: 53.0.0_maintenance
Choose a base branch
from

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 10, 2025

Which issue does this PR close?

Rationale for this change

Rust 1.84 was released yesterday: https://blog.rust-lang.org/2025/01/09/Rust-1.84.0.html

It

  1. introduced some new clippy lints that fail on the 53 maintenance branch.
  2. Renamed the wasm target (see https://blog.rust-lang.org/2024/04/09/updates-to-rusts-wasi-targets.html)

What changes are included in this PR?

  1. Ignore the clippy lints (they are fixed for real on main but there is no reason to potentially destabilize 53 with code changes)
  2. Update the CI to use the new wasm names

Are there any user-facing changes?

no

@github-actions github-actions bot added parquet Changes to the parquet crate arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate labels Jan 10, 2025
@alamb alamb changed the title [53.0.0_maintenance] Fix CI by ignoring some clippy lints introduced in rust 1.84 [53.0.0_maintenance] Fix CI Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate object-store Object Store Interface parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant