-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MINOR] Delete temp file from docs #836
Conversation
Codecov Report
@@ Coverage Diff @@
## master #836 +/- ##
=======================================
Coverage 82.60% 82.60%
=======================================
Files 168 168
Lines 48040 48040
=======================================
Hits 39685 39685
Misses 8355 8355 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can consider adding it to the gitignore or adopt tempfile pattern
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this is likely not the cleanest solution available I think it is simple and fixes the problem so I am going to merge it in.
If anyone else has a chance, cleaning it up to @jimexist 's suggestion (e.g. use tempfile) that would be great 🙏
🤔 well the test fails on https://github.com/apache/arrow-rs/pull/836/checks?check_run_id=3930315965 and rather than spending time debugging it I am going to take @jimexist 's advice and use |
* Delete temp file from docs * fix * Use gitignore instead
Which issue does this PR close?
Closes #835
Rationale for this change
It is annoying that a file is left around after running
cargo test
Prior to this PR, when you run
cargo test --all
the following file is present:What changes are included in this PR?
Remove file in doc tests
Are there any user-facing changes?
No