Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark boolean comparison kernels public #913

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Nov 4, 2021

Which issue does this PR close?

Closes #912

Rationale for this change

The boolean kernels added in #844 by @Dandandan are not marked pub and thus can not be used. For example:

https://docs.rs/arrow/6.1.0/arrow/compute/kernels/comparison/index.html?search=eq_bool

What changes are included in this PR?

mark the boolean kernels public

Are there any user-facing changes?

kernels are usable

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 4, 2021
Copy link
Contributor

@Dandandan Dandandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops 😬 ! Thank you @alamb

@codecov-commenter
Copy link

Codecov Report

Merging #913 (1f50200) into master (d5a4bd7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 1f50200 differs from pull request most recent head 1ca308a. Consider uploading reports for the commit 1ca308a to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #913   +/-   ##
=======================================
  Coverage   82.29%   82.30%           
=======================================
  Files         168      168           
  Lines       48028    48028           
=======================================
+ Hits        39526    39530    +4     
+ Misses       8502     8498    -4     
Impacted Files Coverage Δ
arrow/src/compute/kernels/comparison.rs 92.63% <100.00%> (ø)
parquet/src/encodings/encoding.rs 93.71% <0.00%> (+0.19%) ⬆️
parquet_derive/src/parquet_field.rs 66.21% <0.00%> (+0.22%) ⬆️
arrow/src/array/transform/mod.rs 85.47% <0.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5a4bd7...1ca308a. Read the comment docs.

@alamb
Copy link
Contributor Author

alamb commented Nov 4, 2021

Oops 😬 ! Thank you @alamb

LOL I should have caught it in review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

boolean comparison kernels are not pub (and can't be used)
3 participants