Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Review compute function names #17265

Closed
asfimport opened this issue Jul 9, 2020 · 5 comments
Closed

[C++] Review compute function names #17265

asfimport opened this issue Jul 9, 2020 · 5 comments
Assignees
Labels
Milestone

Comments

@asfimport
Copy link
Collaborator

asfimport commented Jul 9, 2020

We should probably make compute function naming more consistent while it's not too late.

Examples:

  • "isin", "minmax" but "less_equal", "or_kleene", "binary_contains_exact"
  • "binary_contains_exact" only works on string types
  • "ascii_length" accepts non-ascii input and simply counts the number of bytes
  • "partition_to_indices" vs. "NthToIndices"

Reporter: Antoine Pitrou / @pitrou
Assignee: Antoine Pitrou / @pitrou

Related issues:

PRs and other links:

Note: This issue was originally created as ARROW-9390. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Antoine Pitrou / @pitrou:
Also, perhaps the "strptime" function should instead be a variant of "cast"?

@asfimport
Copy link
Collaborator Author

Kouhei Sutou / @kou:
Can we mark this as a blocker of 1.0.0?

@asfimport
Copy link
Collaborator Author

Antoine Pitrou / @pitrou:
Probably.

@asfimport
Copy link
Collaborator Author

Wes McKinney / @wesm:
@pitrou I'd prefer for "cast" to only deal with non-parametric type conversions (the data-loss / safe-unsafe flags don't count as conversion parameters per se)

Yes I agree with a review / normalization of function names before it's too late

@asfimport
Copy link
Collaborator Author

Antoine Pitrou / @pitrou:
Issue resolved by pull request 7755
#7755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants