Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-9390: [C++][Followup] Add underscores to is* string functions #7764

Closed
wants to merge 2 commits into from
Closed

ARROW-9390: [C++][Followup] Add underscores to is* string functions #7764

wants to merge 2 commits into from

Conversation

wesm
Copy link
Member

@wesm wesm commented Jul 14, 2020

No description provided.

@wesm
Copy link
Member Author

wesm commented Jul 14, 2020

cc @nealrichardson

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-9390

nealrichardson
nealrichardson approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a typo in a comment but code LGTM, thanks!

@wesm wesm closed this in f131fe6 Jul 14, 2020
@wesm wesm deleted the cpp-compute-more-renaming branch July 14, 2020 21:41
@asfimport asfimport mentioned this pull request Jul 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nealrichardson nealrichardson nealrichardson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wesm @nealrichardson