Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] [Packaging] Developing + {LIBARROW_BINARY=true} #27839

Closed
asfimport opened this issue Mar 17, 2021 · 0 comments · Fixed by #38236
Closed

[R] [Packaging] Developing + {LIBARROW_BINARY=true} #27839

asfimport opened this issue Mar 17, 2021 · 0 comments · Fixed by #38236
Assignees
@assignUser
Labels
Component: Packaging Component: R Type: enhancement
Milestone
14.0.2

Comments

@asfimport
Copy link
Collaborator

As far as I can tell from reading configure + nixlibs.sh, if one tries to use {LIBARROW_BINARY=true}} on a source checkout there really isn't a binary to be found to install. The installation process does mention that a binary isn't found + it will build from source.

I don't know that we need to support installing a binary from a development branch (afterall, it's entirely possible libarrow would no longer be compatible with the r package) but I think we should fail a little bit more loudly (or express that the binary install will not be attempted because it looks like one is building from a source checkout (possibly detected by seeing if the version is ~x.x.x.9000)).

Alternatively, we could add date-guessing and attempt to download the nightly libarrow corresponding to that.

Reporter: Jonathan Keane / @jonkeane

Note: This issue was originally created as ARROW-12008. Please see the migration documentation for further details.
@paleolimbot paleolimbot mentioned this issue Oct 6, 2023
Open
@assignUser assignUser mentioned this issue Oct 11, 2023
Merged
@github-actions github-actions bot mentioned this issue Oct 13, 2023
Merged
assignUser added a commit that referenced this issue Oct 25, 2023
@assignUser @paleolimbot
GH-27839: [R] Fetch latest nightly binary for arrow R dev versions. (#…
2a4e0db 
…38236)

### Rationale for this change

We currently need to manually download the latest nightly build as the ".9000' dev version never matches any nightly builds.

### What changes are included in this PR?

Check the nightly  repo html listing for the latest version matching the local major version.
Refactor  nixlibs.R and integrate the functionality of winlibs.R  into it to simplify maintenance and prepare for the future of in-line windows libarrow builds.

These changes are build on #38195 so once that is merged I will rebase this.

### Are these changes tested?

Crossbow
* Closes: #27839

Lead-authored-by: Jacob Wujciak-Jens <[email protected]>
Co-authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Jacob Wujciak-Jens <[email protected]>
@assignUser assignUser added this to the 15.0.0 milestone Oct 25, 2023
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 25, 2023
@assignUser @paleolimbot @JerAguilon
apacheGH-27839: [R] Fetch latest nightly binary for arrow R dev versi…
62d0b47 
…ons. (apache#38236)

### Rationale for this change

We currently need to manually download the latest nightly build as the ".9000' dev version never matches any nightly builds.

### What changes are included in this PR?

Check the nightly  repo html listing for the latest version matching the local major version.
Refactor  nixlibs.R and integrate the functionality of winlibs.R  into it to simplify maintenance and prepare for the future of in-line windows libarrow builds.

These changes are build on apache#38195 so once that is merged I will rebase this.

### Are these changes tested?

Crossbow
* Closes: apache#27839

Lead-authored-by: Jacob Wujciak-Jens <[email protected]>
Co-authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Jacob Wujciak-Jens <[email protected]>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Nov 13, 2023
@assignUser @paleolimbot @thisisnic
apacheGH-27839: [R] Fetch latest nightly binary for arrow R dev versi…
af21333 
…ons. (apache#38236)

### Rationale for this change

We currently need to manually download the latest nightly build as the ".9000' dev version never matches any nightly builds.

### What changes are included in this PR?

Check the nightly  repo html listing for the latest version matching the local major version.
Refactor  nixlibs.R and integrate the functionality of winlibs.R  into it to simplify maintenance and prepare for the future of in-line windows libarrow builds.

These changes are build on apache#38195 so once that is merged I will rebase this.

### Are these changes tested?

Crossbow
* Closes: apache#27839

Lead-authored-by: Jacob Wujciak-Jens <[email protected]>
Co-authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Jacob Wujciak-Jens <[email protected]>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@assignUser @paleolimbot @loicalleyne
apacheGH-27839: [R] Fetch latest nightly binary for arrow R dev versi…
4bd364b 
…ons. (apache#38236)

### Rationale for this change

We currently need to manually download the latest nightly build as the ".9000' dev version never matches any nightly builds.

### What changes are included in this PR?

Check the nightly  repo html listing for the latest version matching the local major version.
Refactor  nixlibs.R and integrate the functionality of winlibs.R  into it to simplify maintenance and prepare for the future of in-line windows libarrow builds.

These changes are build on apache#38195 so once that is merged I will rebase this.

### Are these changes tested?

Crossbow
* Closes: apache#27839

Lead-authored-by: Jacob Wujciak-Jens <[email protected]>
Co-authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Jacob Wujciak-Jens <[email protected]>
@assignUser assignUser modified the milestones: 15.0.0, 14.0.2 Nov 27, 2023
raulcd pushed a commit that referenced this issue Nov 28, 2023
@assignUser @paleolimbot @raulcd
GH-27839: [R] Fetch latest nightly binary for arrow R dev versions. (#…
66ca387 
…38236)

### Rationale for this change

We currently need to manually download the latest nightly build as the ".9000' dev version never matches any nightly builds.

### What changes are included in this PR?

Check the nightly  repo html listing for the latest version matching the local major version.
Refactor  nixlibs.R and integrate the functionality of winlibs.R  into it to simplify maintenance and prepare for the future of in-line windows libarrow builds.

These changes are build on #38195 so once that is merged I will rebase this.

### Are these changes tested?

Crossbow
* Closes: #27839

Lead-authored-by: Jacob Wujciak-Jens <[email protected]>
Co-authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Jacob Wujciak-Jens <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@assignUser @paleolimbot @dgreiss
apacheGH-27839: [R] Fetch latest nightly binary for arrow R dev versi…
7575fee 
…ons. (apache#38236)

### Rationale for this change

We currently need to manually download the latest nightly build as the ".9000' dev version never matches any nightly builds.

### What changes are included in this PR?

Check the nightly  repo html listing for the latest version matching the local major version.
Refactor  nixlibs.R and integrate the functionality of winlibs.R  into it to simplify maintenance and prepare for the future of in-line windows libarrow builds.

These changes are build on apache#38195 so once that is merged I will rebase this.

### Are these changes tested?

Crossbow
* Closes: apache#27839

Lead-authored-by: Jacob Wujciak-Jens <[email protected]>
Co-authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Jacob Wujciak-Jens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@assignUser assignUser

Labels
Component: Packaging Component: R Type: enhancement
Projects
None yet
Milestone
14.0.2
Development

Successfully merging a pull request may close this issue.

GH-27839: [R] Fetch latest nightly binary for arrow R dev versions. assignUser/arrow
2 participants
@assignUser @asfimport