Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][Docs] Docs preview jobs failing #38711

Closed
AlenkaF opened this issue Nov 14, 2023 · 8 comments · Fixed by #38723
Closed

[CI][Docs] Docs preview jobs failing #38711

AlenkaF opened this issue Nov 14, 2023 · 8 comments · Fixed by #38723

Comments

@AlenkaF
Copy link
Member

AlenkaF commented Nov 14, 2023

Describe the bug, including details regarding any error messages, version, and platform.

The crossbow docs preview jobs have started failing with message:

Run aws s3 cp build/docs/ $BUCKET/pr_docs/38693/ --recursive
/home/runner/work/_temp/70d5ef2e-28c6-49e6-8af5-fca87c77e[1](https://github.com/ursacomputing/crossbow/actions/runs/6860473195/job/18654366354#step:10:1)39.sh: line 1: aws: command not found
Error: Process completed with exit code 127.

on the Upload preview to S3 step.

Examples:

cc @assignUser

Component(s)

Continuous Integration

@llama90
Copy link
Contributor

llama90 commented Nov 14, 2023

Hello,

It seems that the workflow file you're referring to, possibly github.linux.yml, does not include a step for installing the AWS CLI. Here's a script that might work for adding such a step:

- name: Install AWS CLI
  run: |
    curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip" -o "awscliv2.zip"
    unzip awscliv2.zip
    sudo ./aws/install

I'm curious if creating a PR and then leaving a comment like @github-actions crossbow submit preview-docs would execute the workflow based on the files in the PR.

@AlenkaF
Copy link
Member Author

AlenkaF commented Nov 14, 2023

I'm curious if creating a PR and then leaving a comment like @github-actions crossbow submit preview-docs would execute the workflow based on the files in the PR.

Yes, that is exactly the workflow that is failing: #38693 (comment).

@llama90
Copy link
Contributor

llama90 commented Nov 14, 2023

Thank you for the response.

Interestingly, the current runner image seems to be deployed with AWS CLI 2.13.30 as part of the CLI Tools, according to the Ubuntu2204-Readme.md.

Until about a month ago, preview-docs was working fine, but there have been two image updates since then: on Oct 19 and Oct 26, as seen in the commit history of Ubuntu2204-Readme.md.

Umm… It seems like someone with expertise in this area should take a look at this issue… While explicitly installing AWS CLI might work, it feels like a simplistic approach. I apologize for any confusion caused.

@kou
Copy link
Member

kou commented Nov 14, 2023

Oh, sorry.
I should have not removed aws-cli related files in GH-38233.
Could you remove aws-cli related rm -rf from ci/scripts/util_free_space.sh?

kou pushed a commit that referenced this issue Nov 15, 2023
### Rationale for this change

Restored the Runner image to not delete `aws-cli` for the execution of the `preview-docs` command.

### Are these changes tested?

No

### Are there any user-facing changes?

No

* Closes: #38711

Authored-by: Hyunseok Seo <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 15.0.0 milestone Nov 15, 2023
@AlenkaF
Copy link
Member Author

AlenkaF commented Nov 15, 2023

Thank you @llama90 for the help!

@AlenkaF
Copy link
Member Author

AlenkaF commented Nov 16, 2023

@kou I am not sure why the docs are still failing to build on this PR:
#38693
https://github.com/ursacomputing/crossbow/actions/runs/6888918318/job/18738847448

The preview build should take changes from main and not from the PR right?

@kou
Copy link
Member

kou commented Nov 16, 2023

Could you rebase on main? The PR branch (not main) needs to have this fix.

@AlenkaF
Copy link
Member Author

AlenkaF commented Nov 16, 2023

Aha! Will do, thank you!

dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
…he#38723)

### Rationale for this change

Restored the Runner image to not delete `aws-cli` for the execution of the `preview-docs` command.

### Are these changes tested?

No

### Are there any user-facing changes?

No

* Closes: apache#38711

Authored-by: Hyunseok Seo <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants