-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R] Add debug output to r/configure in case of failure #38756
Comments
As noted on Zulip, a failed download would also be good to log by default! |
#38769 has an interesting failure
|
I think there is somewhere in the either nixlibs.R or configure that is swallowing an error and continuing, which probably means that the MacOS check failure also happens earlier than the test compile stage (we just don't know what it is because we don't produce any output). I think we should probably enable all output at this point: at one point we were trying to actively suppress output that would raise eyebrows with respect to CRAN policy, but I think we are better off enabling all the output by default. We sent them an email telling them what we do: since they already know, the best thing we can do to respect their time (and ours) is to give enough output to reasonably diagnose an install failure. |
Yes totally agree
I actually don't think so (unless its in the unpack/unlink commands but those don't have errors or warning supressed so they should pop up). After the checksum validation nothing happens that could throw an error. There is code that checks/sets flags which could misbehave and cause the test compile error of course... |
### Rationale for this change It hinders debug-ability for users if the failing log doesn't include all info by default. ### What changes are included in this PR? Add debug output to test compile command in r/configure and always display output with regards to the binary download. ### Are these changes tested? crossbow, locally * Closes: #38756 Lead-authored-by: Jacob Wujciak-Jens <[email protected]> Co-authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
…pache#38819) ### Rationale for this change It hinders debug-ability for users if the failing log doesn't include all info by default. ### What changes are included in this PR? Add debug output to test compile command in r/configure and always display output with regards to the binary download. ### Are these changes tested? crossbow, locally * Closes: apache#38756 Lead-authored-by: Jacob Wujciak-Jens <[email protected]> Co-authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
### Rationale for this change It hinders debug-ability for users if the failing log doesn't include all info by default. ### What changes are included in this PR? Add debug output to test compile command in r/configure and always display output with regards to the binary download. ### Are these changes tested? crossbow, locally * Closes: #38756 Lead-authored-by: Jacob Wujciak-Jens <[email protected]> Co-authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
…pache#38819) ### Rationale for this change It hinders debug-ability for users if the failing log doesn't include all info by default. ### What changes are included in this PR? Add debug output to test compile command in r/configure and always display output with regards to the binary download. ### Are these changes tested? crossbow, locally * Closes: apache#38756 Lead-authored-by: Jacob Wujciak-Jens <[email protected]> Co-authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
…pache#38819) ### Rationale for this change It hinders debug-ability for users if the failing log doesn't include all info by default. ### What changes are included in this PR? Add debug output to test compile command in r/configure and always display output with regards to the binary download. ### Are these changes tested? crossbow, locally * Closes: apache#38756 Lead-authored-by: Jacob Wujciak-Jens <[email protected]> Co-authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
Describe the enhancement requested
We have already enabled printing of the complete cmake log in case of a build issue. We should do something similar for the test compile command in
r/configure
(and potentially other places in that file that are ambious with their error messages?)Component(s)
R
The text was updated successfully, but these errors were encountered: