Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java][CI] ci/scripts/java_build.sh can build Arrow Java multiple times #38832

Closed
pitrou opened this issue Nov 21, 2023 · 0 comments · Fixed by #38829
Closed

[Java][CI] ci/scripts/java_build.sh can build Arrow Java multiple times #38832

pitrou opened this issue Nov 21, 2023 · 0 comments · Fixed by #38829
Assignees
@pitrou
Labels
Component: Continuous Integration Component: Java Type: bug
Milestone
15.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Nov 21, 2023

Describe the bug, including details regarding any error messages, version, and platform.

ci/scripts/java_build.sh can invoke mvn install several times on the Arrow Java codebase. This happens especially in JNI and Integration builds, which have some optional components enabled.

Component(s)

Continuous Integration, Java
@github-actions github-actions bot mentioned this issue Nov 21, 2023
Merged
pitrou added a commit that referenced this issue Nov 21, 2023
@pitrou @davisusanibar
GH-38832: [Java] Avoid building twice in ci/scripts/java_build.sh (#…
3af33bc 
…38829)

### Rationale for this change

`ci/scripts/java_build.sh` can invoke `mvn install` several times on the Arrow Java codebase. This happens especially in JNI and Integration builds, which have some optional components enabled.

### What changes are included in this PR?

Only invoke `mvn install` once. This change seems to save around 5 minutes on the JNI and Integration builds.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.

* Closes: #38832

Lead-authored-by: Antoine Pitrou <[email protected]>
Co-authored-by: Antoine Pitrou <[email protected]>
Co-authored-by: david dali susanibar arce <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
@pitrou pitrou added this to the 15.0.0 milestone Nov 21, 2023
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@pitrou @davisusanibar @dgreiss
apacheGH-38832: [Java] Avoid building twice in `ci/scripts/java_build…
f598606 
….sh` (apache#38829)

### Rationale for this change

`ci/scripts/java_build.sh` can invoke `mvn install` several times on the Arrow Java codebase. This happens especially in JNI and Integration builds, which have some optional components enabled.

### What changes are included in this PR?

Only invoke `mvn install` once. This change seems to save around 5 minutes on the JNI and Integration builds.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.

* Closes: apache#38832

Lead-authored-by: Antoine Pitrou <[email protected]>
Co-authored-by: Antoine Pitrou <[email protected]>
Co-authored-by: david dali susanibar arce <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pitrou pitrou

Labels
Component: Continuous Integration Component: Java Type: bug
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-38832: [Java] Avoid building twice in ci/scripts/java_build.sh pitrou/arrow
1 participant
@pitrou