-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++] Path processing on different platforms #39023
Comments
Does this work? diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index 978f03198..3a6f36350 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -975,9 +975,11 @@ set(EP_COMMON_CMAKE_ARGS
# Enable s/ccache if set by parent.
if(CMAKE_C_COMPILER_LAUNCHER AND CMAKE_CXX_COMPILER_LAUNCHER)
+ file(TO_CMAKE_PATH "${CMAKE_C_COMPILER_LAUNCHER}" EP_CMAKE_C_COMPILER_LAUNCHER)
+ file(TO_CMAKE_PATH "${CMAKE_CXX_COMPILER_LAUNCHER}" EP_CMAKE_CXX_COMPILER_LAUNCHER)
list(APPEND EP_COMMON_CMAKE_ARGS
- -DCMAKE_C_COMPILER_LAUNCHER=${CMAKE_C_COMPILER_LAUNCHER}
- -DCMAKE_CXX_COMPILER_LAUNCHER=${CMAKE_CXX_COMPILER_LAUNCHER})
+ -DCMAKE_C_COMPILER_LAUNCHER=${EP_CMAKE_C_COMPILER_LAUNCHER}
+ -DCMAKE_CXX_COMPILER_LAUNCHER=${EP_CMAKE_CXX_COMPILER_LAUNCHER})
endif()
if(NOT ARROW_VERBOSE_THIRDPARTY_BUILD) |
I don't have You can ask @autoantwort to help test it. |
Sorry for the late reply. This patch fixes the issue 👍 |
kou
added a commit
to kou/arrow
that referenced
this issue
Jan 25, 2025
Thanks. I've opened a PR for it: GH-45349 |
kou
added a commit
that referenced
this issue
Jan 25, 2025
…nalPackage (#45349) ### Rationale for this change We need to convert it on Windows. ### What changes are included in this PR? Convert it to CMake path. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: #39023 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Issue resolved by pull request 45349 |
lriggs
pushed a commit
to lriggs/arrow
that referenced
this issue
Jan 30, 2025
… ExternalPackage (apache#45349) ### Rationale for this change We need to convert it on Windows. ### What changes are included in this PR? Convert it to CMake path. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#39023 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
This is a copy of microsoft/vcpkg#35242. Maybe the path needs to be processed:
Windows does not recognize the following path because its delimiter is
\
instead of/
:Is it possible to pass a path representation similar to that used by CMake to solve the problem.
Component(s)
C/C++
The text was updated successfully, but these errors were encountered: