-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-40974: [CI][Python] CI failures on Python builds due to pytest_cython #40975
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! added one comment about tracking unpinning
docker-compose.yml
Outdated
# pytest-cython needs an upper pin of 0.3.0 due | ||
# to an issue with typing annotiations | ||
# https://github.com/lgpage/pytest-cython/issues/67 | ||
# With 0.3.* bug fix release, the pin can be removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth creating a GH issue to unpin and add the issue # in the comment here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, will do!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: #41002
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit bbeeb33. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
…st_cython (apache#40975) ### Rationale for this change We are seeing sporadic CI failures on Python builds due to `pytest_cython`. ### What changes are included in this PR? Upper pin of 0.3.0 added for `pytest-cython`. ### Are these changes tested? With a green CI. ### Are there any user-facing changes? No. * GitHub Issue: apache#40974 Authored-by: AlenkaF <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…st_cython (apache#40975) ### Rationale for this change We are seeing sporadic CI failures on Python builds due to `pytest_cython`. ### What changes are included in this PR? Upper pin of 0.3.0 added for `pytest-cython`. ### Are these changes tested? With a green CI. ### Are there any user-facing changes? No. * GitHub Issue: apache#40974 Authored-by: AlenkaF <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Rationale for this change
We are seeing sporadic CI failures on Python builds due to
pytest_cython
.What changes are included in this PR?
Upper pin of 0.3.0 added for
pytest-cython
.Are these changes tested?
With a green CI.
Are there any user-facing changes?
No.