Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-40974: [CI][Python] CI failures on Python builds due to pytest_cython #40975

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

AlenkaF
Copy link
Member

@AlenkaF AlenkaF commented Apr 3, 2024

Rationale for this change

We are seeing sporadic CI failures on Python builds due to pytest_cython.

What changes are included in this PR?

Upper pin of 0.3.0 added for pytest-cython.

Are these changes tested?

With a green CI.

Are there any user-facing changes?

No.

@github-actions github-actions bot added the awaiting review Awaiting review label Apr 3, 2024
@AlenkaF AlenkaF marked this pull request as draft April 3, 2024 13:53
@AlenkaF AlenkaF marked this pull request as ready for review April 3, 2024 15:00
@AlenkaF AlenkaF requested a review from pitrou April 3, 2024 15:01
Copy link
Member

@danepitkin danepitkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! added one comment about tracking unpinning

# pytest-cython needs an upper pin of 0.3.0 due
# to an issue with typing annotiations
# https://github.com/lgpage/pytest-cython/issues/67
# With 0.3.* bug fix release, the pin can be removed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth creating a GH issue to unpin and add the issue # in the comment here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, will do!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: #41002

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Apr 3, 2024
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Apr 4, 2024
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Apr 4, 2024
@AlenkaF AlenkaF requested a review from kou April 4, 2024 11:41
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit bbeeb33 into apache:main Apr 4, 2024
14 checks passed
@kou kou removed the awaiting change review Awaiting change review label Apr 4, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Apr 4, 2024
@AlenkaF AlenkaF deleted the pin-pytest-cython branch April 4, 2024 13:46
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit bbeeb33.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

tolleybot pushed a commit to tmct/arrow that referenced this pull request May 2, 2024
…st_cython (apache#40975)

### Rationale for this change

We are seeing sporadic CI failures on Python builds due to `pytest_cython`.

### What changes are included in this PR?

Upper pin of 0.3.0 added for `pytest-cython`.

### Are these changes tested?

With a green CI.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#40974

Authored-by: AlenkaF <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
…st_cython (apache#40975)

### Rationale for this change

We are seeing sporadic CI failures on Python builds due to `pytest_cython`.

### What changes are included in this PR?

Upper pin of 0.3.0 added for `pytest-cython`.

### Are these changes tested?

With a green CI.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#40974

Authored-by: AlenkaF <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants