Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-38984: [Python][Packaging] Verification of wheels on AlmaLinux 8 are failing due to missing pip #38985

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Nov 29, 2023

Rationale for this change

Almalinux 8 has been updated from 8.8 to 8.9. When using 8.9 python3 seems to be shipped without pip as the command python3 -m pip install -U pip fails to find pip.

What changes are included in this PR?

Use the ensurepip package which provides support for bootstrapping the pip installer into an existing Python installation.

Are these changes tested?

Yes via archery.

Are there any user-facing changes?

No

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Nov 29, 2023
@raulcd
Copy link
Member Author

raulcd commented Nov 29, 2023

@github-actions crossbow submit wheel-manylinux-2-28-cp38-amd64

Copy link

Revision: 0e6b6a8

Submitted crossbow builds: ursacomputing/crossbow @ actions-81d4bb8bcf

Task Status
wheel-manylinux-2-28-cp38-amd64 Github Actions

@raulcd
Copy link
Member Author

raulcd commented Nov 29, 2023

@github-actions crossbow submit wheel-manylinux-2-28-cp38-amd64

Copy link

Revision: 98084a5

Submitted crossbow builds: ursacomputing/crossbow @ actions-7ae64bcfcb

Task Status
wheel-manylinux-2-28-cp38-amd64 Github Actions

@raulcd
Copy link
Member Author

raulcd commented Nov 29, 2023

@github-actions crossbow submit wheel-manylinux--cp38-

@raulcd raulcd marked this pull request as ready for review November 29, 2023 10:27
Copy link

Revision: 98084a5

Submitted crossbow builds: ursacomputing/crossbow @ actions-f7e804a44d

Task Status
wheel-manylinux-2-28-cp38-amd64 Github Actions
wheel-manylinux-2-28-cp38-arm64 Github Actions
wheel-manylinux-2014-cp38-amd64 Github Actions
wheel-manylinux-2014-cp38-arm64 Github Actions

@kou kou changed the title GH-38984: [Python][Packaging] Verification of wheels on Almalinux 8 are failing due to missing pip GH-38984: [Python][Packaging] Verification of wheels on AlmaLinux 8 are failing due to missing pip Nov 29, 2023
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

It seems that we can remove python38-*:

python38-devel \
python38-pip \

Because it seems that recent AlmaLinux 8 installs python3.11-pip-wheel by dnf -y groupinstall "Development Tools":

https://github.com/ursacomputing/crossbow/actions/runs/7016111614/job/19086656171#step:10:677

Can we try removing python38-* in this PR? Or should we do it in a follow-up PR?

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Nov 29, 2023
@raulcd
Copy link
Member Author

raulcd commented Nov 30, 2023

@github-actions crossbow submit wheel-manylinux--cp38-

Copy link

Revision: e059d2c

Submitted crossbow builds: ursacomputing/crossbow @ actions-c9dbc2c813

Task Status
wheel-manylinux-2-28-cp38-amd64 Github Actions
wheel-manylinux-2-28-cp38-arm64 Github Actions
wheel-manylinux-2014-cp38-amd64 Github Actions
wheel-manylinux-2014-cp38-arm64 Github Actions

@raulcd
Copy link
Member Author

raulcd commented Nov 30, 2023

Can we try removing python38-* in this PR? Or should we do it in a follow-up PR?

I've removed them on this PR and have re-run the wheels. Let me know if you are ok with that. Thanks @kou !

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Thanks! I'll merge this.

@kou kou merged commit 2760faf into apache:main Dec 1, 2023
@kou kou removed the awaiting merge Awaiting merge label Dec 1, 2023
@github-actions github-actions bot added the awaiting merge Awaiting merge label Dec 1, 2023
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 2760faf.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

raulcd added a commit that referenced this pull request Dec 4, 2023
…re failing due to missing pip (#38985)

### Rationale for this change

Almalinux 8 has been updated from 8.8 to 8.9. When using 8.9 python3 seems to be shipped without pip as  the command `python3 -m pip install -U pip` fails to find pip.

### What changes are included in this PR?

Use the [ensurepip package](https://docs.python.org/3/library/ensurepip.html) which provides support for bootstrapping the pip installer into an existing Python installation.

### Are these changes tested?

Yes via archery.

### Are there any user-facing changes?

No
* Closes: #38984

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…ux 8 are failing due to missing pip (apache#38985)

### Rationale for this change

Almalinux 8 has been updated from 8.8 to 8.9. When using 8.9 python3 seems to be shipped without pip as  the command `python3 -m pip install -U pip` fails to find pip.

### What changes are included in this PR?

Use the [ensurepip package](https://docs.python.org/3/library/ensurepip.html) which provides support for bootstrapping the pip installer into an existing Python installation.

### Are these changes tested?

Yes via archery.

### Are there any user-facing changes?

No
* Closes: apache#38984

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Python][[Packaging] Wheels are failing for manylinux python 3.8 due to pip not being found
2 participants