GH-39849: [Python] Remove the use of pytest-lazy-fixture #39850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
github-actions
bot
added
awaiting changes
|
The failures shouldn't be related, but I do not see them on any other build 🤷♀️ |
|
@github-actions crossbow submit python |
|
Revision: c740098 Submitted crossbow builds: ursacomputing/crossbow @ actions-34647c76a2
|
|
Maybe the failures are connected to the new version of pytest. WIll pin it back to see if that is true. |
|
@github-actions crossbow submit -g python |
|
Revision: e4146cb Submitted crossbow builds: ursacomputing/crossbow @ actions-07f4a3b8ab
|
github-actions
bot
added
awaiting changes
jorisvandenbossche
approved these changes
Feb 1, 2024
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 44d5597. There were 2 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This was referenced Feb 6, 2024
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…e#39850) ### Rationale for this change Removing the use of `pytest-lazy-fixture` in our test suite as it is unmaintained. Changes in this PR include: - Remove the use of `pytest-lazy-fixture` - Remove marks from fixtures to avoid future error, see ``` PytestRemovedIn9Warning: Marks applied to fixtures have no effect See docs: https://docs.pytest.org/en/stable/deprecations.html#applying-a-mark-to-a-fixture-function ``` - Catch two different warnings in `def test_legacy_int_type()` ### Are these changes tested? The changes affect the tests so they must pass. ### Are there any user-facing changes? No. * Closes: apache#39849 Lead-authored-by: AlenkaF <[email protected]> Co-authored-by: Joris Van den Bossche <[email protected]> Signed-off-by: Joris Van den Bossche <[email protected]>
raulcd
pushed a commit
that referenced
this pull request
Feb 20, 2024
### Rationale for this change
Removing the use of `pytest-lazy-fixture` in our test suite as it is unmaintained.
Changes in this PR include:
- Remove the use of `pytest-lazy-fixture`
- Remove marks from fixtures to avoid future error, see
```
PytestRemovedIn9Warning: Marks applied to fixtures have no effect
See docs: https://docs.pytest.org/en/stable/deprecations.html#applying-a-mark-to-a-fixture-function
```
- Catch two different warnings in `def test_legacy_int_type()`
### Are these changes tested?
The changes affect the tests so they must pass.
### Are there any user-facing changes?
No.
* Closes: #39849
Lead-authored-by: AlenkaF <[email protected]>
Co-authored-by: Joris Van den Bossche <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Feb 28, 2024
…e#39850) ### Rationale for this change Removing the use of `pytest-lazy-fixture` in our test suite as it is unmaintained. Changes in this PR include: - Remove the use of `pytest-lazy-fixture` - Remove marks from fixtures to avoid future error, see ``` PytestRemovedIn9Warning: Marks applied to fixtures have no effect See docs: https://docs.pytest.org/en/stable/deprecations.html#applying-a-mark-to-a-fixture-function ``` - Catch two different warnings in `def test_legacy_int_type()` ### Are these changes tested? The changes affect the tests so they must pass. ### Are there any user-facing changes? No. * Closes: apache#39849 Lead-authored-by: AlenkaF <[email protected]> Co-authored-by: Joris Van den Bossche <[email protected]> Signed-off-by: Joris Van den Bossche <[email protected]>
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Mar 8, 2024
…e#39850) ### Rationale for this change Removing the use of `pytest-lazy-fixture` in our test suite as it is unmaintained. Changes in this PR include: - Remove the use of `pytest-lazy-fixture` - Remove marks from fixtures to avoid future error, see ``` PytestRemovedIn9Warning: Marks applied to fixtures have no effect See docs: https://docs.pytest.org/en/stable/deprecations.html#applying-a-mark-to-a-fixture-function ``` - Catch two different warnings in `def test_legacy_int_type()` ### Are these changes tested? The changes affect the tests so they must pass. ### Are there any user-facing changes? No. * Closes: apache#39849 Lead-authored-by: AlenkaF <[email protected]> Co-authored-by: Joris Van den Bossche <[email protected]> Signed-off-by: Joris Van den Bossche <[email protected]>
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Mar 25, 2024
pytest-lazy-fixture is no longer used apache/arrow#39850
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Removing the use of
pytest-lazy-fixturein our test suite as it is unmaintained.Changes in this PR include:
pytest-lazy-fixturedef test_legacy_int_type()Are these changes tested?
The changes affect the tests so they must pass.
Are there any user-facing changes?
No.