GH-39962: [C++] Small CSV reader refactoring #39963
Merged
+45
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@github-actions crossbow submit -g cpp |
This comment was marked as outdated.
This comment was marked as outdated.
pitrou
force-pushed
the
gh39962-csv-reader-refactor
branch
from
f8b9e84 to
7284df9
Compare
|
@github-actions crossbow submit -g cpp |
This comment was marked as outdated.
This comment was marked as outdated.
bkietz
approved these changes
Feb 7, 2024
github-actions
bot
added
awaiting merge
pitrou
force-pushed
the
gh39962-csv-reader-refactor
branch
from
f8e976e to
2fb237e
Compare
pitrou
force-pushed
the
gh39962-csv-reader-refactor
branch
from
2fb237e to
2804b2a
Compare
|
@github-actions crossbow submit -g cpp |
|
Revision: 2804b2a Submitted crossbow builds: ursacomputing/crossbow @ actions-79e6f2b964
|
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit de3cdc0. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### What changes are included in this PR? Factor our some shared functionality in the CSV reader to avoid code duplication. ### Are these changes tested? Yes, by existing tests. ### Are there any user-facing changes? No. * Closes: apache#39962 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Feb 28, 2024
### What changes are included in this PR? Factor our some shared functionality in the CSV reader to avoid code duplication. ### Are these changes tested? Yes, by existing tests. ### Are there any user-facing changes? No. * Closes: apache#39962 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Mar 8, 2024
### What changes are included in this PR? Factor our some shared functionality in the CSV reader to avoid code duplication. ### Are these changes tested? Yes, by existing tests. ### Are there any user-facing changes? No. * Closes: apache#39962 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
Factor our some shared functionality in the CSV reader to avoid code duplication.
Are these changes tested?
Yes, by existing tests.
Are there any user-facing changes?
No.