Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Add test for flatbuffers serialization #41018

Closed
wants to merge 6 commits into from

Conversation

amoeba
Copy link
Member

@amoeba amoeba commented Apr 4, 2024

This is a draft PR that shouldn't get merged.

This is testing the test described in #40361. Once the test has done its job on CI, I'll add a follow-up commit to make the test pass by updating the affected code. Once that happens, I'll add the test to the PR for #40361 and we can merge it.

Rationale for this change

The test should have different result on different platforms in CI which will help us show that any regression test we add to #40361 will do its job.

What changes are included in this PR?

New test.

Are these changes tested?

No, this PR is for testing on CI.

Are there any user-facing changes?

No.

Copy link

github-actions bot commented Apr 4, 2024

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@amoeba
Copy link
Member Author

amoeba commented Apr 4, 2024

The test added by this PR succeeds on macOS (where I generated the test data) and fails on my Linux machine so I think that's a start. I'll wait for CI and return to this when that's all been run.

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Apr 8, 2024
@pitrou
Copy link
Member

pitrou commented Apr 8, 2024

@github-actions crossbow submit -g cpp

Copy link

github-actions bot commented Apr 8, 2024

Revision: 2e32daa

Submitted crossbow builds: ursacomputing/crossbow @ actions-fb843adca5

Task Status
test-alpine-linux-cpp GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind Azure
test-cuda-cpp GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-fedora-39-cpp GitHub Actions
test-ubuntu-20.04-cpp GitHub Actions
test-ubuntu-20.04-cpp-bundled GitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizer GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions

@pitrou
Copy link
Member

pitrou commented Apr 8, 2024

Ok, the test nicely fails on a number of C++ builds :-)

@amoeba
Copy link
Member Author

amoeba commented Apr 8, 2024

That's good, thanks for taking a look @pitrou. Do you think this is in good enough shape to add to #40392?

@pitrou
Copy link
Member

pitrou commented Apr 9, 2024

Yes, it is. Thank you @amoeba !

@amoeba amoeba closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants