-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++] Add test for flatbuffers serialization #41018
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of PARQUET issues on JIRA the title also supports:
See also: |
The test added by this PR succeeds on macOS (where I generated the test data) and fails on my Linux machine so I think that's a start. I'll wait for CI and return to this when that's all been run. |
@github-actions crossbow submit -g cpp |
Revision: 2e32daa Submitted crossbow builds: ursacomputing/crossbow @ actions-fb843adca5 |
Ok, the test nicely fails on a number of C++ builds :-) |
Yes, it is. Thank you @amoeba ! |
This is a draft PR that shouldn't get merged.
This is testing the test described in #40361. Once the test has done its job on CI, I'll add a follow-up commit to make the test pass by updating the affected code. Once that happens, I'll add the test to the PR for #40361 and we can merge it.
Rationale for this change
The test should have different result on different platforms in CI which will help us show that any regression test we add to #40361 will do its job.
What changes are included in this PR?
New test.
Are these changes tested?
No, this PR is for testing on CI.
Are there any user-facing changes?
No.