-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-41039: [Python] ListView pandas tests should use np.nan instead of None #41040
Conversation
@github-actions crossbow submit -g python |
|
Revision: 6c1be46 Submitted crossbow builds: ursacomputing/crossbow @ actions-88b36e596b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit bf3c1b9. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…ead of None (apache#41040) ### Rationale for this change ListView pandas conversion tests are failing in upstream development branches of pandas/numpy. ### What changes are included in this PR? * Use np.nan instead of None when comparing with an expected Pandas Series. ### Are these changes tested? Yes, unit tests updated. ### Are there any user-facing changes? No. * GitHub Issue: apache#41039 Authored-by: Dane Pitkin <[email protected]> Signed-off-by: AlenkaF <[email protected]>
…ead of None (apache#41040) ### Rationale for this change ListView pandas conversion tests are failing in upstream development branches of pandas/numpy. ### What changes are included in this PR? * Use np.nan instead of None when comparing with an expected Pandas Series. ### Are these changes tested? Yes, unit tests updated. ### Are there any user-facing changes? No. * GitHub Issue: apache#41039 Authored-by: Dane Pitkin <[email protected]> Signed-off-by: AlenkaF <[email protected]>
Rationale for this change
ListView pandas conversion tests are failing in upstream development branches of pandas/numpy.
What changes are included in this PR?
Are these changes tested?
Yes, unit tests updated.
Are there any user-facing changes?
No.