GH-39294: [C++][Python] DLPack on Tensor class #42118
Draft
+232
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: C++
Component: Python
awaiting review
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
Comment on lines
+164
to
+168
| std::vector<int64_t>* strides_arr = &ctx->strides; | ||
| strides_arr->resize(t->ndim()); | ||
| for (int i = 0; i < t->ndim(); i++) { | ||
| (*strides_arr)[i] = t->strides().data()[i] / t->type()->byte_width(); | ||
| } |
There was a problem hiding this comment.
I am entirely sure if this was written this way for performance, but my feeling is that this is quite complicated written, and you should also be able to just iterate through the values in t->strides() and add them to &ctx->strides with more standard std::vector functionality.
(for example, have a look at FixedShapeTensorArray::FromTensor how some of the vectors are being created)
github-actions
bot
added
awaiting changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Producing part of DLPack protocol has been added to Arrow Arrays but is missing on Arrow Tensor class.
What changes are included in this PR?
This PR adds support for producing DLPack struct and bindings to it in Python:
ExportTensorandExportTensorDevicemethods on Arrow C++ Tensor class__dlpack__method on PyArrow Tensor class exposing ExportTensor method__dlpack_device__method on PyArrow Tensor class exposing ExportTensorDevice methodAre these changes tested?
Yes
Are there any user-facing changes?
No