GH-43202: [C++][Compute] Detect and explicit error for offset overflow in row table

[zanmato1984]

Rationale for this change

There are two places for the offset in a row table to possibly overflow: 1) Encoding columns into a row table; 2) Appending to a row table from another row table.

They are particularly bad because they can cause silent wrong result for the computation.

What changes are included in this PR?

Detect such overflows in the aforementioned places and report an explicit error when an overflow is detected.

Are these changes tested?

UT included.

Are there any user-facing changes?

User code that used to be fake passing could see an explicit error after this change.

This PR contains a "Critical Fix".

• GitHub Issue: [C++][Compute] Possible overflow of row table offsets #43202

[github-actions]

⚠️ GitHub issue #43202 has been automatically assigned in GitHub to PR creator.

[zanmato1984]

Hi @pitrou @westonpace , would you like to take a look? Thanks.

[zanmato1984]

@github-actions crossbow submit -g cpp

[zanmato1984]

@github-actions crossbow submit -g cpp

[github-actions]

Revision: ae34ac4

Submitted crossbow builds: ursacomputing/crossbow @ actions-72e104db5c

Task	Status
test-alpine-linux-cpp
test-build-cpp-fuzz
test-conda-cpp
test-conda-cpp-valgrind
test-cuda-cpp
test-debian-12-cpp-amd64
test-debian-12-cpp-i386
test-fedora-39-cpp
test-ubuntu-20.04-cpp
test-ubuntu-20.04-cpp-bundled
test-ubuntu-20.04-cpp-minimal-with-formats
test-ubuntu-20.04-cpp-thread-sanitizer
test-ubuntu-22.04-cpp
test-ubuntu-22.04-cpp-20
test-ubuntu-22.04-cpp-emscripten
test-ubuntu-22.04-cpp-no-threading
test-ubuntu-24.04-cpp
test-ubuntu-24.04-cpp-gcc-14

[pitrou]

Should we drop/clear the row_table after this to release a bit of memory?

[zanmato1984]

Thanks for looking!

Every time an encoder encodes into a row table, the row table gets effectively cleared. So the memory is only hold til the next EncodeSelected call. Clearing it here doesn't make much difference I guess(?) - the code in between is relatively trivial.

[pitrou]

Ah, ok, thank you

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit cf5d7c7.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.