Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-40216: [CI][Packaging][Python] Upload pyarrow nightly wheels to scientific python channel on Anaconda #43862

Merged
merged 16 commits into from
Sep 2, 2024

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Aug 28, 2024

Rationale for this change

As discussed on the main issue is interesting for discoverability to have the wheels uploaded to the nightly channel.

What changes are included in this PR?

Added macro to upload wheel to scientific python channel

Are these changes tested?

Via archery

Are there any user-facing changes?

No but nightly wheels will be available on scientific python channel

Copy link

⚠️ GitHub issue #40216 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Aug 28, 2024
@raulcd
Copy link
Member Author

raulcd commented Aug 28, 2024

@github-actions crossbow submit wheel-macos-catalina-cp310-amd64

Copy link

Revision: bc682b1

Submitted crossbow builds: ursacomputing/crossbow @ actions-534b800acb

Task Status
wheel-macos-catalina-cp310-amd64 GitHub Actions

@raulcd
Copy link
Member Author

raulcd commented Aug 28, 2024

we can't use the action on non-linux. I'll try to upload manually

@raulcd
Copy link
Member Author

raulcd commented Aug 28, 2024

@github-actions crossbow submit wheel-macos-catalina-cp310-amd64

This comment was marked as outdated.

@raulcd
Copy link
Member Author

raulcd commented Aug 28, 2024

@github-actions crossbow submit wheel-macos-catalina-cp310-amd64

This comment was marked as outdated.

@raulcd
Copy link
Member Author

raulcd commented Aug 28, 2024

@github-actions crossbow submit wheel-macos-catalina-cp310-amd64

This comment was marked as outdated.

@raulcd
Copy link
Member Author

raulcd commented Aug 28, 2024

@github-actions crossbow submit wheel-macos-catalina-cp310-amd64

This comment was marked as outdated.

@raulcd
Copy link
Member Author

raulcd commented Aug 28, 2024

@github-actions crossbow submit wheel-macos-catalina-cp310-amd64

This comment was marked as outdated.

@raulcd
Copy link
Member Author

raulcd commented Aug 28, 2024

@github-actions crossbow submit wheel-macos-catalina-cp310-amd64

This comment was marked as outdated.

@raulcd
Copy link
Member Author

raulcd commented Aug 28, 2024

@github-actions crossbow submit wheel-macos-catalina-cp310-amd64

This comment was marked as outdated.

@raulcd
Copy link
Member Author

raulcd commented Aug 28, 2024

@github-actions crossbow submit wheel-macos-catalina-cp310-amd64

@raulcd
Copy link
Member Author

raulcd commented Aug 29, 2024

Revision: 8662076

Submitted crossbow builds: ursacomputing/crossbow @ test-upload-scientific-2

Task Status
python-sdist GitHub Actions
wheel-macos-big-sur-cp310-arm64 GitHub Actions
wheel-macos-big-sur-cp311-arm64 GitHub Actions
wheel-macos-big-sur-cp312-arm64 GitHub Actions
wheel-macos-big-sur-cp313-arm64 GitHub Actions
wheel-macos-big-sur-cp38-arm64 GitHub Actions
wheel-macos-big-sur-cp39-arm64 GitHub Actions
wheel-macos-catalina-cp310-amd64 GitHub Actions
wheel-macos-catalina-cp311-amd64 GitHub Actions
wheel-macos-catalina-cp312-amd64 GitHub Actions
wheel-macos-catalina-cp313-amd64 GitHub Actions
wheel-macos-catalina-cp38-amd64 GitHub Actions
wheel-macos-catalina-cp39-amd64 GitHub Actions
wheel-manylinux-2-28-cp310-amd64 GitHub Actions
wheel-manylinux-2-28-cp310-arm64 GitHub Actions
wheel-manylinux-2-28-cp311-amd64 GitHub Actions
wheel-manylinux-2-28-cp311-arm64 GitHub Actions
wheel-manylinux-2-28-cp312-amd64 GitHub Actions
wheel-manylinux-2-28-cp312-arm64 GitHub Actions
wheel-manylinux-2-28-cp313-amd64 GitHub Actions
wheel-manylinux-2-28-cp313-arm64 GitHub Actions
wheel-manylinux-2-28-cp38-amd64 GitHub Actions
wheel-manylinux-2-28-cp38-arm64 GitHub Actions
wheel-manylinux-2-28-cp39-amd64 GitHub Actions
wheel-manylinux-2-28-cp39-arm64 GitHub Actions
wheel-manylinux-2014-cp310-amd64 GitHub Actions
wheel-manylinux-2014-cp310-arm64 GitHub Actions
wheel-manylinux-2014-cp311-amd64 GitHub Actions
wheel-manylinux-2014-cp311-arm64 GitHub Actions
wheel-manylinux-2014-cp312-amd64 GitHub Actions
wheel-manylinux-2014-cp312-arm64 GitHub Actions
wheel-manylinux-2014-cp313-amd64 GitHub Actions
wheel-manylinux-2014-cp313-arm64 GitHub Actions
wheel-manylinux-2014-cp38-amd64 GitHub Actions
wheel-manylinux-2014-cp38-arm64 GitHub Actions
wheel-manylinux-2014-cp39-amd64 GitHub Actions
wheel-manylinux-2014-cp39-arm64 GitHub Actions
wheel-windows-cp310-amd64 GitHub Actions
wheel-windows-cp311-amd64 GitHub Actions
wheel-windows-cp312-amd64 GitHub Actions
wheel-windows-cp313-amd64 GitHub Actions
wheel-windows-cp38-amd64 GitHub Actions
wheel-windows-cp39-amd64 GitHub Actions

@raulcd raulcd marked this pull request as ready for review August 29, 2024 11:20
@raulcd
Copy link
Member Author

raulcd commented Aug 29, 2024

@jorisvandenbossche all wheels have been uploaded successfully, see: https://anaconda.org/scientific-python-nightly-wheels/pyarrow/files

I will remove the version: 18.0.0.dev236 once we merge the PR and we can let the nightlies to get uploaded.

@@ -29,6 +29,7 @@ groups:

wheel:
- wheel-*
- python-sdist
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the sdist as part of the wheels job as several times we want to also trigger it when we trigger the wheels group but happy to remove it from here if we want to have it separate

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Aug 29, 2024
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Can we drop support for Gemfury?

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting changes Awaiting changes labels Aug 29, 2024
Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, much easier than doing it here!

Can we drop support for Gemfury?

I think we should discuss that in a separate issue?

@raulcd
Copy link
Member Author

raulcd commented Sep 2, 2024

I think is a good idea to drop uploading wheels to gemfury. I've created:

to follow that up.

Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 3a6135b.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

jorisvandenbossche added a commit that referenced this pull request Sep 3, 2024
… of scientific-python-nightly-wheels channel (#43932)

### Rationale for this change

Small follow-up on #43862, correcting the `label` being used to upload the wheels. See #40216 (comment) for context.

* GitHub Issue: #40216

Authored-by: Joris Van den Bossche <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
mapleFU pushed a commit to mapleFU/arrow that referenced this pull request Sep 3, 2024
… to scientific python channel on Anaconda (apache#43862)

### Rationale for this change

As discussed on the main issue is interesting for discoverability to have the wheels uploaded to the nightly channel.

### What changes are included in this PR?

Added macro to upload wheel to scientific python channel

### Are these changes tested?

Via archery

### Are there any user-facing changes?

No but nightly wheels will be available on scientific python channel
* GitHub Issue: apache#40216

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Jacob Wujciak-Jens <[email protected]>
mapleFU pushed a commit to mapleFU/arrow that referenced this pull request Sep 3, 2024
… label of scientific-python-nightly-wheels channel (apache#43932)

### Rationale for this change

Small follow-up on apache#43862, correcting the `label` being used to upload the wheels. See apache#40216 (comment) for context.

* GitHub Issue: apache#40216

Authored-by: Joris Van den Bossche <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Sep 6, 2024
… to scientific python channel on Anaconda (apache#43862)

### Rationale for this change

As discussed on the main issue is interesting for discoverability to have the wheels uploaded to the nightly channel.

### What changes are included in this PR?

Added macro to upload wheel to scientific python channel

### Are these changes tested?

Via archery

### Are there any user-facing changes?

No but nightly wheels will be available on scientific python channel
* GitHub Issue: apache#40216

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Jacob Wujciak-Jens <[email protected]>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Sep 6, 2024
… label of scientific-python-nightly-wheels channel (apache#43932)

### Rationale for this change

Small follow-up on apache#43862, correcting the `label` being used to upload the wheels. See apache#40216 (comment) for context.

* GitHub Issue: apache#40216

Authored-by: Joris Van den Bossche <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
khwilson pushed a commit to khwilson/arrow that referenced this pull request Sep 14, 2024
… to scientific python channel on Anaconda (apache#43862)

### Rationale for this change

As discussed on the main issue is interesting for discoverability to have the wheels uploaded to the nightly channel.

### What changes are included in this PR?

Added macro to upload wheel to scientific python channel

### Are these changes tested?

Via archery

### Are there any user-facing changes?

No but nightly wheels will be available on scientific python channel
* GitHub Issue: apache#40216

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Jacob Wujciak-Jens <[email protected]>
khwilson pushed a commit to khwilson/arrow that referenced this pull request Sep 14, 2024
… label of scientific-python-nightly-wheels channel (apache#43932)

### Rationale for this change

Small follow-up on apache#43862, correcting the `label` being used to upload the wheels. See apache#40216 (comment) for context.

* GitHub Issue: apache#40216

Authored-by: Joris Van den Bossche <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants