GH-44369: [CI][Python] Remove ds requirement from test collection on test_dataset.py #44370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on on test_dataset.py
|
|
|
@github-actions crossbow submit example-python-minimal-build-* |
|
Revision: d682c4f Submitted crossbow builds: ursacomputing/crossbow @ actions-b410c377ee
|
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit e0d1f51. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
raulcd
added a commit
that referenced
this pull request
Oct 11, 2024
…test_dataset.py (#44370) ### Rationale for this change If pyarrow has been built without dataset test collection errors due to pytest.mark.parametrize requiring dataset. ### What changes are included in this PR? Move dataset requirement outside of test collection by removing it from the parametrization. ### Are these changes tested? Via archery ### Are there any user-facing changes? No * GitHub Issue: #44369 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
If pyarrow has been built without dataset test collection errors due to pytest.mark.parametrize requiring dataset.
What changes are included in this PR?
Move dataset requirement outside of test collection by removing it from the parametrization.
Are these changes tested?
Via archery
Are there any user-facing changes?
No