-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-44422: [Packaging][Release][Linux] Upload artifacts before test #44425
Conversation
@github-actions crossbow submit centos-9-stream-arm64 |
|
This comment was marked as outdated.
This comment was marked as outdated.
@github-actions crossbow submit centos-9-stream-arm64 |
This comment was marked as outdated.
This comment was marked as outdated.
@github-actions crossbow submit centos-9-stream-arm64 |
Revision: fe18d22 Submitted crossbow builds: ursacomputing/crossbow @ actions-9c3d235999
|
The job failed but artifacts were uploaded: https://github.com/ursacomputing/crossbow/releases/tag/actions-9c3d235999-github-centos-9-stream-arm64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as a temporary solution
…44425) ### Rationale for this change It seems that the current `quay.io/centos/centos:stream9` for `linux/aarch64` is broken. We use it for building and testing but testing is only broken for now. Because we use cached (a bit old) `quay.io/centos/centos:stream9` for now. Building will be failed when the cache is expired. ### What changes are included in this PR? Change upload phase to after the build from after the test. Test is still failing but we can proceed our release process by this. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #44422 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 0577ff6. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
It seems that the current
quay.io/centos/centos:stream9
forlinux/aarch64
is broken.We use it for building and testing but testing is only broken for now. Because we use cached (a bit old)
quay.io/centos/centos:stream9
for now. Building will be failed when the cache is expired.What changes are included in this PR?
Change upload phase to after the build from after the test. Test is still failing but we can proceed our release process by this.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.