Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44422: [Packaging][Release][Linux] Upload artifacts before test #44425

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

kou
Copy link
Member

@kou kou commented Oct 16, 2024

Rationale for this change

It seems that the current quay.io/centos/centos:stream9 for linux/aarch64 is broken.

We use it for building and testing but testing is only broken for now. Because we use cached (a bit old) quay.io/centos/centos:stream9 for now. Building will be failed when the cache is expired.

What changes are included in this PR?

Change upload phase to after the build from after the test. Test is still failing but we can proceed our release process by this.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@kou
Copy link
Member Author

kou commented Oct 16, 2024

@github-actions crossbow submit centos-9-stream-arm64

Copy link

⚠️ GitHub issue #44422 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Oct 16, 2024

This comment was marked as outdated.

@kou
Copy link
Member Author

kou commented Oct 16, 2024

@github-actions crossbow submit centos-9-stream-arm64

This comment was marked as outdated.

@kou
Copy link
Member Author

kou commented Oct 16, 2024

@github-actions crossbow submit centos-9-stream-arm64

Copy link

Revision: fe18d22

Submitted crossbow builds: ursacomputing/crossbow @ actions-9c3d235999

Task Status
centos-9-stream-arm64 GitHub Actions

@kou kou changed the title GH-44422: [Packaging][Release] Fix centos-9 on arm64 test GH-44422: [Packaging][Release][Linux] Upload artifacts before test Oct 16, 2024
@kou
Copy link
Member Author

kou commented Oct 16, 2024

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a temporary solution

@raulcd raulcd merged commit 0577ff6 into apache:main Oct 16, 2024
9 checks passed
@raulcd raulcd removed the awaiting committer review Awaiting committer review label Oct 16, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Oct 16, 2024
raulcd pushed a commit that referenced this pull request Oct 16, 2024
…44425)

### Rationale for this change

It seems that the current `quay.io/centos/centos:stream9` for `linux/aarch64` is broken.

We use it for building and testing but testing is only broken for now. Because we use cached (a bit old) `quay.io/centos/centos:stream9` for now. Building will be failed when the cache is expired.

### What changes are included in this PR?

Change upload phase to after the build from after the test. Test is still failing but we can proceed our release process by this.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #44422

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
@kou kou deleted the centos-9-arm64 branch October 16, 2024 11:37
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 0577ff6.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants