Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45380: [Python] Expose RankQuantileOptions to Python #45392

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Jan 30, 2025

Rationale for this change

RankQuantileOptions are currently not exposed on Pyarrow and CI job breaks when -W error is used.

What changes are included in this PR?

Expose RankQuantileOptions and test options and kernel from pyarrow.

It also includes some minor refactor for the unwrap sort keys logic to move it into a common function.

Are these changes tested?

Yes

Are there any user-facing changes?

The options for the new kernel are exposed on pyarrow.

@raulcd
Copy link
Member Author

raulcd commented Jan 30, 2025

@github-actions crossbow submit test-conda-python-3.11-hypothesis

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jan 30, 2025
Copy link

Revision: ff3a84d

Submitted crossbow builds: ursacomputing/crossbow @ actions-c71ec9f5c5

Task Status
test-conda-python-3.11-hypothesis GitHub Actions

@raulcd
Copy link
Member Author

raulcd commented Jan 30, 2025

The sporadic failure on test-conda-python-3.11-hypothesis is a different issue tracked here:

The RankQuantileOptions warning for it not being exposed has been solved.

edit: the job was successful on retry

@raulcd raulcd requested a review from pitrou January 30, 2025 11:16
python/pyarrow/_compute.pyx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants