Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44761: [GLib] Add garrow_table_validate() #45414

Merged
merged 9 commits into from
Feb 5, 2025

Conversation

hiroyuki-sato
Copy link
Collaborator

@hiroyuki-sato hiroyuki-sato commented Feb 2, 2025

Rationale for this change

Table::Validate is available in the C++ API.
But, GLib doesn't support that method yet.

What changes are included in this PR?

This PR adds a validation method in the table class.
Before this change, the Validate() method was used in
garrow_table_new_values(), garrow_table_new_arrays(),
and garrow_table_new_chunked_arrays() functions implicitly.
This PR removes them and adds it as a separate method.
Users need to call garrow_table_validate() explicitly by themselves.
This is a backward incompatible change.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

This PR includes breaking changes to public APIs.

@hiroyuki-sato hiroyuki-sato requested a review from kou as a code owner February 2, 2025 13:37
Copy link

github-actions bot commented Feb 2, 2025

⚠️ GitHub issue #44761 has been automatically assigned in GitHub to PR creator.

c_glib/test/test-table.rb Outdated Show resolved Hide resolved
c_glib/test/test-table.rb Outdated Show resolved Hide resolved
c_glib/test/test-table.rb Outdated Show resolved Hide resolved
c_glib/test/test-table.rb Outdated Show resolved Hide resolved
c_glib/test/test-table.rb Outdated Show resolved Hide resolved
c_glib/arrow-glib/table.cpp Show resolved Hide resolved
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Feb 2, 2025
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Feb 2, 2025
c_glib/test/test-table.rb Outdated Show resolved Hide resolved
c_glib/test/test-table.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Feb 4, 2025
hiroyuki-sato and others added 2 commits February 4, 2025 21:14
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Feb 4, 2025
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Feb 5, 2025
@kou kou merged commit 2cbc7d6 into apache:main Feb 5, 2025
11 checks passed
@kou kou removed the awaiting merge Awaiting merge label Feb 5, 2025
@hiroyuki-sato hiroyuki-sato deleted the topic/arrow-table-validate branch February 5, 2025 03:33
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 2cbc7d6.

There were 8 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants