-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-45393: [C++][Compute] Fix wrong decoding for 32-bit column in row table #45473
Conversation
|
fa43cd6
to
0b81f6e
Compare
@ursabot please benchmark lang=R |
Benchmark runs are scheduled for commit 0b81f6e. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete. |
Thanks for your patience. Conbench analyzed the 3 benchmarking runs that have been run so far on PR commit 0b81f6e. There were 2 benchmark results indicating a performance regression:
The full Conbench report has more details. |
The reported performance regression shouldn't be related. I'm merging this now to get our CI back to green sooner than later. |
Thanks for the quick fix @zanmato1984 ! |
Thanks for the fix! |
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit d3c4676. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
The failure reported in #45393 seems to be caused by a careless parentheses typo introduced in #45336:
arrow/cpp/src/arrow/compute/row/encode_internal.cc
Lines 281 to 282 in e32f56b
And unfortunately our
Grouper
UT doesn't have cases covering this particular code path (the questioning code path is only triggered inGrouper
with very restrictive conditions: the row table is fixed-length, a 32-bit key is encoded after some other keys).What changes are included in this PR?
An UT to reproduce the issue and the fix.
Are these changes tested?
UT included.
Are there any user-facing changes?
None.