Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] Add Reset method to buffer and cleanup comments on component. #6369

Closed
wants to merge 26 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
bd08d0e
ARROW-7712: [CI] [Crossbow] Delete fuzzit jobs
pitrou Jan 30, 2020
942a4d0
ARROW-6738: [Java] Fix problems with current union comparison logic
liyafan82 Feb 3, 2020
49aada2
ARROW-7734: [C++] check status details for nullptr in equality
lidavidm Feb 3, 2020
af24bb7
ARROW-6724: [C++] Allow simpler BufferOutputStream creation
pitrou Feb 3, 2020
85996e6
ARROW-6871: [Java] Enhance TransferPair related parameters check and …
tianchen92 Feb 3, 2020
4c7bfc7
ARROW-7301: [Java] Sql type DATE should correspond to DateDayVector
liyafan82 Feb 3, 2020
ab3d86e
ARROW-7736: [Release] Retry binary download on transient error
kou Feb 3, 2020
19b0d4b
ARROW-7466: [CI][Java] Fix gandiva-jar-osx nightly build failure
kszucs Feb 3, 2020
d091894
ARROW-7684: [Rust] Example Flight client and server for DataFusion
andygrove Feb 3, 2020
68c2f3c
ARROW-7729: [Python][CI] Pin pandas version to 0.25 in the dask integ…
kszucs Feb 3, 2020
cb81f7d
ARROW-7735: [Release][Python] Use pip to install dependencies for whe…
kszucs Feb 3, 2020
4b54997
ARROW-7726: [CI] [C++] Use boost binaries on Windows GHA build
pitrou Feb 3, 2020
bc261d1
ARROW-7073: [Java] Support concating vectors values in batch
liyafan82 Feb 4, 2020
a605417
ARROW-7750: [Release] Make the source release verification script res…
kszucs Feb 4, 2020
0326ea3
ARROW-7751: [Release] macOS wheel verification also needs arrow-testing
nealrichardson Feb 4, 2020
d6b6f87
ARROW-7691: [C++] Check non-scalar Flatbuffers fields are not null
pitrou Feb 4, 2020
09059d5
ARROW-7760: [Release] Fix verify-release-candidate.sh since pip3 seem…
wesm Feb 4, 2020
b7dbbcc
ARROW-6757: [Release] Use same CMake generator for C++ and Python whe…
wesm Feb 4, 2020
992d9fc
ARROW-7752: [Release] Enable and test dataset in the verification script
kszucs Feb 4, 2020
67e34c5
ARROW-7766: [Python][Packaging] Windows py38 wheels are built with wr…
nealrichardson Feb 5, 2020
184f828
ARROW-7762: [Python] Do not ignore exception for invalid version in P…
jorisvandenbossche Feb 5, 2020
25fd97b
PARQUET-1716: [C++] Add BYTE_STREAM_SPLIT encoder and decoder
martinradev Feb 5, 2020
c02d376
ARROW-4226: [C++] Add sparse CSF tensor support
rok Feb 5, 2020
a1ba1cb
ARROW-7514: [C#] Make GetValueOffset Obsolete
Feb 5, 2020
12d58e3
Add Reset method to buffer and cleanup comments
Feb 6, 2020
fb57524
Dont reset refcount
Feb 6, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/cpp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -175,10 +175,15 @@ jobs:
ARROW_BUILD_STATIC: OFF
ARROW_BOOST_USE_SHARED: OFF
ARROW_VERBOSE_THIRDPARTY_BUILD: OFF
BOOST_SOURCE: BUNDLED
BOOST_ROOT: C:\local\boost_1_67_0
BOOST_LIBRARYDIR: C:\local\boost_1_67_0\lib64-msvc-14.1\
steps:
- name: Disable Crash Dialogs
run: reg add "HKCU\SOFTWARE\Microsoft\Windows\Windows Error Reporting" /v DontShowUI /t REG_DWORD /d 1 /f
- name: Installed Packages
run: choco list -l
- name: Install Boost
run: choco install -y boost-msvc-14.1
- name: Checkout Arrow
uses: actions/checkout@v1
with:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

[![Build Status](https://ci.appveyor.com/api/projects/status/github/apache/arrow/branch/master?svg=true)](https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/branch/master)
[![Coverage Status](https://codecov.io/gh/apache/arrow/branch/master/graph/badge.svg)](https://codecov.io/gh/apache/arrow?branch=master)
[![Fuzzit Status](https://app.fuzzit.dev/badge?org_id=yMxZh42xl9qy6bvg3EiJ&branch=master)](https://app.fuzzit.dev/admin/yMxZh42xl9qy6bvg3EiJ/dashboard)
[![Fuzzing Status](https://oss-fuzz-build-logs.storage.googleapis.com/badges/arrow.svg)](https://bugs.chromium.org/p/oss-fuzz/issues/list?sort=-opened&can=1&q=proj:arrow)
[![License](http://img.shields.io/:license-Apache%202-blue.svg)](https://github.com/apache/arrow/blob/master/LICENSE.txt)
[![Twitter Follow](https://img.shields.io/twitter/follow/apachearrow.svg?style=social&label=Follow)](https://twitter.com/apachearrow)

Expand Down
3 changes: 3 additions & 0 deletions ci/docker/conda-python-dask.dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,6 @@ FROM ${repo}:${arch}-conda-python-${python}
ARG dask=latest
COPY ci/scripts/install_dask.sh /arrow/ci/scripts/
RUN /arrow/ci/scripts/install_dask.sh ${dask}

# The Spark tests currently break with pandas >= 1.0
RUN if [ ${dask} == "latest" ]; then conda install pandas=0.25.3; fi
47 changes: 0 additions & 47 deletions ci/docker/linux-apt-fuzzit.dockerfile

This file was deleted.

46 changes: 0 additions & 46 deletions ci/scripts/fuzzit_build.sh

This file was deleted.

12 changes: 12 additions & 0 deletions cpp/src/arrow/compare.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1196,6 +1196,13 @@ inline bool SparseTensorEqualsImplDispatch(const SparseTensorImpl<SparseIndexTyp
right_csc);
}

case SparseTensorFormat::CSF: {
const auto& right_csf =
checked_cast<const SparseTensorImpl<SparseCSFIndex>&>(right);
return SparseTensorEqualsImpl<SparseIndexType, SparseCSFIndex>::Compare(left,
right_csf);
}

default:
return false;
}
Expand Down Expand Up @@ -1232,6 +1239,11 @@ bool SparseTensorEquals(const SparseTensor& left, const SparseTensor& right) {
return SparseTensorEqualsImplDispatch(left_csc, right);
}

case SparseTensorFormat::CSF: {
const auto& left_csf = checked_cast<const SparseTensorImpl<SparseCSFIndex>&>(left);
return SparseTensorEqualsImplDispatch(left_csf, right);
}

default:
return false;
}
Expand Down
7 changes: 2 additions & 5 deletions cpp/src/arrow/dataset/file_ipc_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -34,16 +34,14 @@
namespace arrow {
namespace dataset {

constexpr int64_t kDefaultOutputStreamSize = 1024;
constexpr int64_t kBatchSize = 1UL << 12;
constexpr int64_t kBatchRepetitions = 1 << 5;
constexpr int64_t kNumRows = kBatchSize * kBatchRepetitions;

class ArrowIpcWriterMixin : public ::testing::Test {
public:
std::shared_ptr<Buffer> Write(std::vector<RecordBatchReader*> readers) {
EXPECT_OK_AND_ASSIGN(auto sink, io::BufferOutputStream::Create(
kDefaultOutputStreamSize, default_memory_pool()));
EXPECT_OK_AND_ASSIGN(auto sink, io::BufferOutputStream::Create());
auto writer_schema = readers[0]->schema();

EXPECT_OK_AND_ASSIGN(auto writer,
Expand All @@ -69,8 +67,7 @@ class ArrowIpcWriterMixin : public ::testing::Test {
}

std::shared_ptr<Buffer> Write(const Table& table) {
EXPECT_OK_AND_ASSIGN(auto sink, io::BufferOutputStream::Create(
kDefaultOutputStreamSize, default_memory_pool()));
EXPECT_OK_AND_ASSIGN(auto sink, io::BufferOutputStream::Create());

EXPECT_OK_AND_ASSIGN(auto writer,
ipc::RecordBatchFileWriter::Open(sink.get(), table.schema()));
Expand Down
4 changes: 2 additions & 2 deletions cpp/src/arrow/extension_type_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ TEST_F(TestExtensionType, ExtensionTypeTest) {

auto RoundtripBatch = [](const std::shared_ptr<RecordBatch>& batch,
std::shared_ptr<RecordBatch>* out) {
ASSERT_OK_AND_ASSIGN(auto out_stream, io::BufferOutputStream::Create(1024));
ASSERT_OK_AND_ASSIGN(auto out_stream, io::BufferOutputStream::Create());
ASSERT_OK(ipc::WriteRecordBatchStream({batch}, ipc::IpcOptions::Defaults(),
out_stream.get()));

Expand Down Expand Up @@ -255,7 +255,7 @@ TEST_F(TestExtensionType, UnrecognizedExtension) {

// Write full IPC stream including schema, then unregister type, then read
// and ensure that a plain instance of the storage type is created
ASSERT_OK_AND_ASSIGN(auto out_stream, io::BufferOutputStream::Create(1024));
ASSERT_OK_AND_ASSIGN(auto out_stream, io::BufferOutputStream::Create());
ASSERT_OK(ipc::WriteRecordBatchStream({batch}, ipc::IpcOptions::Defaults(),
out_stream.get()));

Expand Down
3 changes: 2 additions & 1 deletion cpp/src/arrow/flight/test_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,8 @@ Status TestClientBasicAuthHandler::GetToken(std::string* token) {
Status GetTestResourceRoot(std::string* out) {
const char* c_root = std::getenv("ARROW_TEST_DATA");
if (!c_root) {
return Status::IOError("Test resources not found, set ARROW_TEST_DATA");
return Status::IOError(
"Test resources not found, set ARROW_TEST_DATA to <repo root>/testing/data");
}
*out = std::string(c_root);
return Status::OK();
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/arrow/io/compressed_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ void CheckCompressedInputStream(Codec* codec, const std::vector<uint8_t>& data)
void CheckCompressedOutputStream(Codec* codec, const std::vector<uint8_t>& data,
bool do_flush) {
// Create compressed output stream
ASSERT_OK_AND_ASSIGN(auto buffer_writer, BufferOutputStream::Create(1024));
ASSERT_OK_AND_ASSIGN(auto buffer_writer, BufferOutputStream::Create());
ASSERT_OK_AND_ASSIGN(auto stream, CompressedOutputStream::Make(codec, buffer_writer));
ASSERT_OK_AND_EQ(0, stream->Tell());

Expand Down
2 changes: 1 addition & 1 deletion cpp/src/arrow/io/memory.h
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class ARROW_EXPORT BufferOutputStream : public OutputStream {
/// \param[in,out] pool a MemoryPool to use for allocations
/// \return the created stream
static Result<std::shared_ptr<BufferOutputStream>> Create(
int64_t initial_capacity, MemoryPool* pool = default_memory_pool());
int64_t initial_capacity = 4096, MemoryPool* pool = default_memory_pool());

ARROW_DEPRECATED("Use Result-returning overload")
static Status Create(int64_t initial_capacity, MemoryPool* pool,
Expand Down
4 changes: 2 additions & 2 deletions cpp/src/arrow/ipc/feather_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ void CheckBatches(const RecordBatch& expected, const RecordBatch& result) {
class TestTableReader : public ::testing::Test {
public:
void SetUp() {
ASSERT_OK_AND_ASSIGN(stream_, io::BufferOutputStream::Create(1024));
ASSERT_OK_AND_ASSIGN(stream_, io::BufferOutputStream::Create());
ASSERT_OK(TableWriter::Open(stream_, &writer_));
}

Expand Down Expand Up @@ -356,7 +356,7 @@ TEST_F(TestTableReader, ReadNames) {
class TestTableWriter : public ::testing::Test {
public:
void SetUp() {
ASSERT_OK_AND_ASSIGN(stream_, io::BufferOutputStream::Create(1024));
ASSERT_OK_AND_ASSIGN(stream_, io::BufferOutputStream::Create());
ASSERT_OK(TableWriter::Open(stream_, &writer_));
}

Expand Down
Loading