Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-9268: [C++] add string_is{alpnum,alpha...,upper} kernels #7656

Closed
wants to merge 28 commits into from
+826 −3
Closed

ARROW-9268: [C++] add string_is{alpnum,alpha...,upper} kernels #7656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
2cd1d8b
ARROW-9268: [C++] add string_is{alpnum,alpha...,upper} kernels
maartenbreddels Jul 7, 2020
08e2898
lint python
maartenbreddels Jul 7, 2020
c85837a
convert arrow scalar to python value
maartenbreddels Jul 7, 2020
afd2207
move utf8proc code to ifdef block
maartenbreddels Jul 7, 2020
ad1c1ac
remove unused variable
maartenbreddels Jul 7, 2020
a1f9935
use UTF8PROC_CATEGORY_CN instead of 0
maartenbreddels Jul 8, 2020
ae9a111
better version of islower/isupper using trick and more tests
maartenbreddels Jul 8, 2020
bdb040c
put tests in place that document what we do not support
maartenbreddels Jul 8, 2020
3c59966
make python tests more robust by ignoring undefined codepoints
maartenbreddels Jul 8, 2020
e01cf19
rename string_func_unicode -> utf8_func
maartenbreddels Jul 8, 2020
674aa38
more tests
maartenbreddels Jul 8, 2020
35091f5
some compilers look at unused templates
maartenbreddels Jul 8, 2020
876e1b8
misplaced ifdefs
maartenbreddels Jul 8, 2020
5227023
use lookup table and use isalnum for benchmark
maartenbreddels Jul 8, 2020
65d674d
use utf8 sequence in string (maybe the compiler does not like the lit…
maartenbreddels Jul 10, 2020
cd426d4
Fix: was not using lut
maartenbreddels Jul 10, 2020
b435b94
performance increase: ~15-20%
maartenbreddels Jul 10, 2020
cb9365c
use different high codepoint that does not require unicode 13
maartenbreddels Jul 10, 2020
f7a4931
Use 'ArrowType' for template parameter instead of clashing 'StringType'
wesm Jul 10, 2020
1e8c5c5
compiler bug workaround
maartenbreddels Jul 11, 2020
68868bd
wrong template argument
maartenbreddels Jul 11, 2020
3739e66
change crtp inheritance
maartenbreddels Jul 11, 2020
e9628a6
CRTP -> inline lambdas
wesm Jul 12, 2020
33bb8bb
Instantiate fewer templates
wesm Jul 12, 2020
a160803
Some fixes, try something else to see if it fixes the gcc compilation…
wesm Jul 12, 2020
2efd9c8
Move LUT initialization out of if block
wesm Jul 12, 2020
ce7869d
Compile without utf8proc
wesm Jul 12, 2020
bc5a2ec
Skip failing test on older utf8proc
wesm Jul 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading