Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-10653: [Rust] Update toolchain nightly #8713

Closed
wants to merge 1 commit into from
Closed

ARROW-10653: [Rust] Update toolchain nightly #8713

wants to merge 1 commit into from

Conversation

vertexclique
Copy link
Contributor

I have deployed new intrinsics to rust lang core, so I want to bring these in iterations.

@codecov-io
Copy link

Codecov Report

Merging #8713 (e4c8e71) into master (256d0dc) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8713      +/-   ##
==========================================
- Coverage   84.51%   84.50%   -0.01%     
==========================================
  Files         177      177              
  Lines       43858    43861       +3     
==========================================
- Hits        37067    37066       -1     
- Misses       6791     6795       +4
Impacted Files Coverage Δ
rust/parquet/src/data_type.rs 84.61% <0.00%> (-1.17%) ⬇️
rust/parquet/src/encodings/encoding.rs 92.99% <0.00%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60ea0dc...e4c8e71. Read the comment docs.

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-10653

@vertexclique
Copy link
Contributor Author

r? @alamb @nevi-me

nevi-me
nevi-me approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@nevi-me nevi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with change

@alamb
Copy link
Contributor

alamb commented Nov 19, 2020

This is cool -- though note I think there is a broader effort afoot to remove the use of rust nightly in Arrow (e.g. #8698)

So I suspect that any use of stuff in nightly rust will likely have to be feature gated to make this work. Just something to keep in mind if you want to introduce more use of such intrinsics into the arrow crates

@alamb
Copy link
Contributor

alamb commented Nov 19, 2020

For the record: rust-lang/rust#79131 perhaps is perhaps the change to rustlang that @vertexclique refers to

@alamb
Copy link
Contributor

alamb commented Nov 19, 2020

FYI @andygrove and @jorgecarleitao

@alamb alamb closed this in ebeea18 Nov 19, 2020
@jorgecarleitao
Copy link
Member

Thanks a lot. LGTM. And as a side note: super cool @vertexclique that you are contributing to rust core! 😍

GeorgeAp pushed a commit to sirensolutions/arrow that referenced this pull request Jun 7, 2021
@vertexclique @GeorgeAp
ARROW-10653: [Rust] Update toolchain nightly
167f27f 
I have deployed new intrinsics to rust lang core, so I want to bring these in iterations.

Closes apache#8713 from vertexclique/ARROW-10653-update-toolchain-nightly

Authored-by: Mahmut Bulut <[email protected]>
Signed-off-by: Andrew Lamb <[email protected]>
@asfimport asfimport mentioned this pull request Nov 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevi-me nevi-me nevi-me approved these changes

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
Component: Rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vertexclique @codecov-io @alamb @jorgecarleitao @nevi-me