ARROW-10933: [Rust] Update readme files in regard to nightly rust #8931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgecarleitao
approved these changes
Dec 15, 2020
andygrove
reviewed
Dec 16, 2020
| `rustfmt`. So before submitting a PR be sure to run the following | ||
| and check for lint issues: | ||
| Our CI uses `rustfmt` to check code formatting. Before submitting a | ||
| PR be sure to run the following and check for lint issues: | ||
|
|
||
| ```bash | ||
| cargo +stable fmt --all -- --check |
There was a problem hiding this comment.
do we still need the +stable flag?
There was a problem hiding this comment.
nm, I suppose people using simd will still be using nightly.
andygrove
approved these changes
Dec 16, 2020
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
Update the docs with respect to changes after apache#8698 Closes apache#8931 from alamb/alamb/ARROW-10933-update-docs Authored-by: Andrew Lamb <[email protected]> Signed-off-by: Andy Grove <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the docs with respect to changes after #8698