ARROW-1366: [Plasma] Define entry point for the plasma store #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcmoritz
force-pushed
the
plasma-store-ep
branch
from
afe7b00 to
57d89ff
Compare
pcmoritz
force-pushed
the
plasma-store-ep
branch
from
57d89ff to
4c05140
Compare
wesm
reviewed
Aug 18, 2017
python/pyarrow/__init__.py
Outdated
| @@ -105,6 +105,16 @@ | |||
|
|
|||
| localfs = LocalFileSystem.get_instance() | |||
|
|
|||
| # Entry point for starting the plasma store | |||
|
|
|||
| def start_plasma_store(): | |||
There was a problem hiding this comment.
Can you add a docstring for this, and add to doc/source/api.rst?
There was a problem hiding this comment.
I'd prefer to not have this as part of the official API, since it is reading arguments from sys.argv; I'll rename it to _plasma_store_entry_point, any idea if there is a file where it fits better?
If we want a function that starts the store, we can move the one from test_plasma into the pyarrow.plasma namespace.
There was a problem hiding this comment.
OK, sounds good. We could have something like pyarrow.plasma.start and pyarrow.plasma.kill
wesm
approved these changes
Aug 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method for starting the Plasma store is already documented in https://arrow.apache.org/docs/python/plasma.html. So far it only worked if the store was installed with "make install" from the C++ sources. This makes it also possible to start it if the pyarrow wheels are installed.