Close the Jackson Generator(#3310)

apache · Feb 26, 2025 · 254f401 · 254f401
1 parent bc4896e
commit 254f401
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/lang/java/avro/src/main/java/org/apache/avro/Schema.java b/lang/java/avro/src/main/java/org/apache/avro/Schema.java
@@ -444,12 +444,13 @@ public String toString(Collection<Schema> referencedSchemas, boolean pretty) {
   String toString(Set<String> knownNames, boolean pretty) {
     try {
       StringWriter writer = new StringWriter();
-      JsonGenerator gen = FACTORY.createGenerator(writer);
-      if (pretty)
-        gen.useDefaultPrettyPrinter();
-      toJson(knownNames, null, gen);
-      gen.flush();
-      return writer.toString();
+      try (JsonGenerator gen = FACTORY.createGenerator(writer)) {
+        if (pretty)
+          gen.useDefaultPrettyPrinter();
+        toJson(knownNames, null, gen);
+        gen.flush();
+        return writer.toString();
+      }
     } catch (IOException e) {
       throw new AvroRuntimeException(e);
     }