Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Go SDK Dataflow jobs fail on DataSampling disabled #29760

Closed
2 of 16 tasks
lostluck opened this issue Dec 13, 2023 · 8 comments · Fixed by #29761
Closed
2 of 16 tasks

[Bug]: Go SDK Dataflow jobs fail on DataSampling disabled #29760

lostluck opened this issue Dec 13, 2023 · 8 comments · Fixed by #29761
Assignees
@lostluck
Labels
bug dataflow go P2
Milestone
2.55.0 Release

Comments

@lostluck
Copy link
Contributor

What happened?

Dataflow is making DataSampling FnAPI requests even when DataSampling is disabled. But since the feature wasn't enabled, the Go SDK isn't initialzing the datasampler, leading to nil pointer panic.

2023-12-08 16:28:11.597 PST
panic({0x1264220?, 0x2786ff0?}) 
2023-12-08 16:28:11.597 PST
	runtime/panic.go:914 +0x21f 
2023-12-08 16:28:11.597 PST
github.com/apache/beam/sdks/v2/go/pkg/beam/core/runtime/exec.(*DataSampler).getAllSamples(0x0) 
2023-12-08 16:28:11.597 PST
	github.com/apache/beam/sdks/v2/go/pkg/beam/core/runtime/exec/datasampler.go:79 +0x4b 
2023-12-08 16:28:11.597 PST
github.com/apache/beam/sdks/v2/go/pkg/beam/core/runtime/exec.(*DataSampler).GetSamples(0x1312c00?, {0x0?, 0xc000234480?, 0xc00053b508?}) 
2023-12-08 16:28:11.597 PST
	github.com/apache/beam/sdks/v2/go/pkg/beam/core/runtime/exec/datasampler.go:62 +0x1d 
2023-12-08 16:28:11.597 PST
github.com/apache/beam/sdks/v2/go/pkg/beam/core/runtime/harness.(*control).handleInstruction(0xc000318000, {0x180beb0?, 0xc000091c80?}, 0xc000147ef0) 
2023-12-08 16:28:11.597 PST
	github.com/apache/beam/sdks/v2/go/pkg/beam/core/runtime/harness/harness.go:668 +0x116f 
2023-12-08 16:28:11.597 PST
github.com/apache/beam/sdks/v2/go/pkg/beam/core/runtime/harness.MainWithOptions.func4({0x180beb0?, 0xc000091c80?}, 0xc000091c80?) 
2023-12-08 16:28:11.597 PST
	github.com/apache/beam/sdks/v2/go/pkg/beam/core/runtime/harness/harness.go:202 +0x74 
2023-12-08 16:28:11.597 PST
github.com/apache/beam/sdks/v2/go/pkg/beam/core/runtime/harness.MainWithOptions({0x180beb0, 0xc000091c20}, {0x7fffd16304e4, 0xf}, {0x7fffd1630507, 0xf}, {{0xc000225e70, 0x1, 0x1}, {0xc000046010, ...}}) 
2023-12-08 16:28:11.597 PST
	github.com/apache/beam/sdks/v2/go/pkg/beam/core/runtime/harness/harness.go:222 +0x1022 
2023-12-08 16:28:11.597 PST
github.com/apache/beam/sdks/v2/go/pkg/beam/core/runtime/harness/init.hook() 
2023-12-08 16:28:11.597 PST
	github.com/apache/beam/sdks/v2/go/pkg/beam/core/runtime/harness/init/init.go:144 +0x50c

Easy enough fix, not caught sooner because we didn't run the Dataflow Go Postcommits.

First: Fix the issue, and cherry pick it into 2.53.0
Second: While this is very unlikely, this would have been caught by a simple Dataflow Go Wordcount test as a pre-commit. I'll add that.

Issue Priority

Priority: 1 (data loss / total loss of function)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@lostluck lostluck added this to the 2.53.0 Release milestone Dec 13, 2023
@lostluck lostluck self-assigned this Dec 13, 2023
@lostluck
Copy link
Contributor Author

cc: @rohdesamuel @zechenj18

@rohdesamuel
Copy link
Contributor

Thanks for opening this!

@lostluck lostluck mentioned this issue Dec 13, 2023
Merged
3 tasks
lostluck pushed a commit that referenced this issue Dec 13, 2023
@zechenj18
[#29760] Only respond to sampling request while data sampling is enab…
19858e9 
…led (#29761)
@lostluck lostluck reopened this Dec 13, 2023
@lostluck
Copy link
Contributor Author

Waiting for
https://github.com/apache/beam/actions/runs/7201639105 to complete, and once that's verified, I'll make a cherry pick PR for it for the release.

@lostluck lostluck mentioned this issue Dec 14, 2023
Merged
3 tasks
jrmccluskey pushed a commit that referenced this issue Dec 14, 2023
@lostluck @zechenj18
[#29760] Only respond to sampling request while data sampling is ena…
f773123 
…bled (#29764)

* Only respond to sampling request while data sampling is enabled

* do not fail runner when data sampling is not enabled

---------

Co-authored-by: Zechen Jiang <[email protected]>
@lostluck
Copy link
Contributor Author

Last outstanding thing here is the Dataflow Smoke test precommit.

@lostluck lostluck changed the title [Bug]: Go SDK Dataflow jobs fail on DataSampling disabl [Bug]: Go SDK Dataflow jobs fail on DataSampling disabled Dec 20, 2023
@lostluck
Copy link
Contributor Author

This is non-blocking but I've punted it's release over.

@damccorm
Copy link
Contributor

damccorm commented Feb 6, 2024

Can we drop this to P2?

@lostluck lostluck added P2 and removed P1 labels Feb 6, 2024
@lostluck
Copy link
Contributor Author

lostluck commented Feb 6, 2024

Agreed.

@Abacn
Copy link
Contributor

Abacn commented Mar 6, 2024

It seems this issue was resolved? The linked workflow run #29760 (comment) was successful

@Abacn Abacn closed this as completed Mar 6, 2024
@Abacn Abacn modified the milestones: 2.55.0 Release, 2.54.0 Release Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lostluck lostluck

Labels
bug dataflow go P2
Projects
None yet
Milestone
2.55.0 Release
Development

Successfully merging a pull request may close this issue.

[#29760] Only respond to sampling request while data sampling is enabled zechenj18/beam
4 participants
@rohdesamuel @Abacn @lostluck @damccorm