Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherrypick #15418 and #15515 #15608

Merged
merged 2 commits into from
Sep 28, 2021

Conversation

dpcollins-google
Copy link
Contributor

  • Port all changes from the Pub/Sub Lite repo back to beam.

Beam will be the canonical source for this IO in the future per offline discussion.

Also add the other direction of helper to CloudPubsubTransforms and add an integration test.

  • remove fixed TODO

  • Fixes to ReadWriteIT to work around Create or DirectRunner bug.

  • fix racy test

(cherry picked from commit 8a646aa)

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

* Port all changes from the Pub/Sub Lite repo back to beam.

Beam will be the canonical source for this IO in the future per offline discussion.

Also add the other direction of helper to CloudPubsubTransforms and add an integration test.

* remove fixed TODO

* Fixes to ReadWriteIT to work around Create or DirectRunner bug.

* fix racy test

(cherry picked from commit 8a646aa)
@dpcollins-google
Copy link
Contributor Author

R: @udim

@udim
Copy link
Member

udim commented Sep 28, 2021

Run Java_Examples_Dataflow PreCommit

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #15608 (d60e52f) into release-2.33.0 (c776883) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-2.33.0   #15608      +/-   ##
==================================================
+ Coverage           83.78%   83.79%   +0.01%     
==================================================
  Files                 440      440              
  Lines               59838    59838              
==================================================
+ Hits                50133    50139       +6     
+ Misses               9705     9699       -6     
Impacted Files Coverage Δ
...ks/python/apache_beam/runners/worker/sdk_worker.py 88.50% <0.00%> (-0.31%) ⬇️
...runners/interactive/display/pcoll_visualization.py 85.78% <0.00%> (+0.52%) ⬆️
sdks/python/apache_beam/runners/direct/executor.py 96.79% <0.00%> (+0.53%) ⬆️
...pache_beam/runners/interactive/interactive_beam.py 76.59% <0.00%> (+1.06%) ⬆️
sdks/python/apache_beam/io/source_test_utils.py 89.86% <0.00%> (+1.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3c869d...d60e52f. Read the comment docs.

@dpcollins-google
Copy link
Contributor Author

Run Java PreCommit

@udim
Copy link
Member

udim commented Sep 28, 2021

Could you also patch in https://github.com/apache/beam/pull/15515/files. I'll be running the precommit tests again myself so it'd help if I can avoid any flaky tests.

@dpcollins-google dpcollins-google changed the title Cherrypick #15418 Cherrypick #15418 and #15515 Sep 28, 2021
@dpcollins-google
Copy link
Contributor Author

I've patched in the one line change from #15515 manually.

@dpcollins-google
Copy link
Contributor Author

Run Java PreCommit

@udim udim merged commit 583e523 into apache:release-2.33.0 Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants