-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-4665] Allow joining a running dataflow pipeline without throwing #16689
[BEAM-4665] Allow joining a running dataflow pipeline without throwing #16689
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16689 +/- ##
==========================================
- Coverage 46.43% 46.38% -0.05%
==========================================
Files 202 202
Lines 19810 19828 +18
==========================================
Hits 9198 9198
- Misses 9625 9643 +18
Partials 987 987
Continue to review full report at Codecov.
|
R: @lostluck |
Run GoPortable PreCommit |
Looks like the portable precommit check is being flaky? Either that or I'm not understanding what its trying to tell me 😬 |
The portable failure looks like an unrelated failure, introduced this morning-ish. https://ci-beam.apache.org/job/beam_PreCommit_GoPortable_Cron/1317/ Not that this PR should be affecting the portable precommit anyway. Since this is dataflow specific we need to run the postcommit (which runs the same suite, on dataflow). |
Run Go Postcommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll wait on the post commit just in case, but otherwise thanks!
This is great! Heck this allows anyone on the same project to get status/monitoring information for an active job, but that's a goal for a different time...
Run Go Postcommit |
…damccorm/join-existing-job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks!
Right now, if you try to run a dataflow pipeline with a defined name in async mode multiple times in a row it throws the second time because a job already exists:
This updates the behavior to just join the existing pipeline and not throw:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunner
compliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.