Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-4665] Allow joining a running dataflow pipeline without throwing #16689

Merged
merged 2 commits into from
Feb 2, 2022

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Feb 1, 2022

Right now, if you try to run a dataflow pipeline with a defined name in async mode multiple times in a row it throws the second time because a job already exists:

image

This updates the behavior to just join the existing pipeline and not throw:

image


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #16689 (a0ebe95) into master (cc0b2c5) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16689      +/-   ##
==========================================
- Coverage   46.43%   46.38%   -0.05%     
==========================================
  Files         202      202              
  Lines       19810    19828      +18     
==========================================
  Hits         9198     9198              
- Misses       9625     9643      +18     
  Partials      987      987              
Impacted Files Coverage Δ
...o/pkg/beam/runners/dataflow/dataflowlib/execute.go 0.00% <0.00%> (ø)
...ks/go/pkg/beam/runners/dataflow/dataflowlib/job.go 14.76% <0.00%> (-1.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc0b2c5...a0ebe95. Read the comment docs.

@damccorm
Copy link
Contributor Author

damccorm commented Feb 1, 2022

R: @lostluck

@damccorm
Copy link
Contributor Author

damccorm commented Feb 1, 2022

Run GoPortable PreCommit

@damccorm
Copy link
Contributor Author

damccorm commented Feb 1, 2022

Looks like the portable precommit check is being flaky? Either that or I'm not understanding what its trying to tell me 😬

@lostluck
Copy link
Contributor

lostluck commented Feb 2, 2022

The portable failure looks like an unrelated failure, introduced this morning-ish. https://ci-beam.apache.org/job/beam_PreCommit_GoPortable_Cron/1317/
It's being discussed and worked on, so it'll probably be fine for a re-run later.

Not that this PR should be affecting the portable precommit anyway. Since this is dataflow specific we need to run the postcommit (which runs the same suite, on dataflow).

@lostluck
Copy link
Contributor

lostluck commented Feb 2, 2022

Run Go Postcommit

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll wait on the post commit just in case, but otherwise thanks!
This is great! Heck this allows anyone on the same project to get status/monitoring information for an active job, but that's a goal for a different time...

@damccorm
Copy link
Contributor Author

damccorm commented Feb 2, 2022

Run Go Postcommit

@damccorm
Copy link
Contributor Author

damccorm commented Feb 2, 2022

@lostluck looks like the integration failures were fixed by #16692, tests are passing again 🎉

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@lostluck lostluck merged commit 716e3b1 into apache:master Feb 2, 2022
@damccorm damccorm deleted the users/damccorm/join-existing-job branch February 3, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants