Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-14059] Deprecate tags.go #17025

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Mar 7, 2022

All the functions in tags.go are unused and should be removed in a future release


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the go label Mar 7, 2022
@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #17025 (cd7e217) into master (77f57d1) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head cd7e217 differs from pull request most recent head c6d1d44. Consider uploading reports for the commit c6d1d44 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17025      +/-   ##
==========================================
- Coverage   73.84%   73.82%   -0.03%     
==========================================
  Files         667      667              
  Lines       87392    87356      -36     
==========================================
- Hits        64536    64487      -49     
- Misses      21750    21763      +13     
  Partials     1106     1106              
Flag Coverage Δ
go 49.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/core/util/reflectx/tags.go 0.00% <ø> (ø)
.../python/apache_beam/testing/test_stream_service.py 88.37% <0.00%> (-4.66%) ⬇️
...ks/python/apache_beam/runners/worker/data_plane.py 87.50% <0.00%> (-1.99%) ⬇️
sdks/python/apache_beam/internal/metrics/metric.py 90.00% <0.00%> (-1.00%) ⬇️
...pache_beam/runners/interactive/interactive_beam.py 80.62% <0.00%> (-0.78%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 91.30% <0.00%> (-0.73%) ⬇️
...runners/interactive/display/pcoll_visualization.py 85.85% <0.00%> (-0.51%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 88.90% <0.00%> (-0.16%) ⬇️
sdks/python/apache_beam/dataframe/frames.py 95.07% <0.00%> (-0.07%) ⬇️
...ython/apache_beam/io/gcp/experimental/spannerio.py 82.31% <0.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77f57d1...c6d1d44. Read the comment docs.

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damccorm
Copy link
Contributor Author

damccorm commented Mar 7, 2022

R: @youngoli for final review

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2022

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@youngoli
Copy link
Contributor

youngoli commented Mar 8, 2022

R: @lostluck

While this looks good to me, I want to wait and get a review from Robert before we merge. Not sure if there's some reason I don't know about to keep these functions. As long as this is in before the next Beam version cut it should be good.

@damccorm damccorm force-pushed the users/damccorm/deprecate-tags branch 2 times, most recently from 533d58f to f3cdbb2 Compare March 8, 2022 18:23
@damccorm damccorm force-pushed the users/damccorm/deprecate-tags branch from f3cdbb2 to c6d1d44 Compare March 8, 2022 18:29
@aaltay aaltay requested a review from lostluck March 18, 2022 01:03
Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@lostluck lostluck merged commit ed56013 into apache:master Mar 18, 2022
@damccorm damccorm deleted the users/damccorm/deprecate-tags branch March 21, 2022 01:33
@damccorm damccorm mentioned this pull request May 4, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants