-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-14059] Deprecate tags.go #17025
[BEAM-14059] Deprecate tags.go #17025
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17025 +/- ##
==========================================
- Coverage 73.84% 73.82% -0.03%
==========================================
Files 667 667
Lines 87392 87356 -36
==========================================
- Hits 64536 64487 -49
- Misses 21750 21763 +13
Partials 1106 1106
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
R: @youngoli for final review |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
R: @lostluck While this looks good to me, I want to wait and get a review from Robert before we merge. Not sure if there's some reason I don't know about to keep these functions. As long as this is in before the next Beam version cut it should be good. |
533d58f
to
f3cdbb2
Compare
f3cdbb2
to
c6d1d44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks!
All the functions in tags.go are unused and should be removed in a future release
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.