-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some auto-starting runners to the typescript SDK. #17580
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import { Pipeline } from "../internal/pipeline"; | ||
import { PipelineResult, Runner } from "./runner"; | ||
import { PortableRunner } from "./portable_runner/runner"; | ||
import { PythonService } from "../utils/service"; | ||
|
||
export function dataflowRunner(runnerOptions: { | ||
project: string; | ||
tempLocation: string; | ||
region: string; | ||
[others: string]: any; | ||
}): Runner { | ||
return new (class extends Runner { | ||
async runPipeline( | ||
pipeline: Pipeline, | ||
options: Object = {} | ||
): Promise<PipelineResult> { | ||
return new PortableRunner( | ||
runnerOptions as any, | ||
new PythonService("apache_beam.runners.dataflow.dataflow_job_service", [ | ||
"--port", | ||
"{{PORT}}", | ||
]) | ||
).runPipeline(pipeline, options); | ||
} | ||
})(); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
const fs = require("fs"); | ||
const os = require("os"); | ||
const path = require("path"); | ||
|
||
import { Pipeline } from "../internal/pipeline"; | ||
import { PipelineResult, Runner } from "./runner"; | ||
import { PortableRunner } from "./portable_runner/runner"; | ||
import { JavaJarService } from "../utils/service"; | ||
|
||
const MAGIC_HOST_NAMES = ["[local]", "[auto]"]; | ||
|
||
// These should stay in sync with gradle.properties. | ||
const PUBLISHED_FLINK_VERSIONS = ["1.12", "1.13", "1.14"]; | ||
|
||
const defaultOptions = { | ||
flinkMaster: "[local]", | ||
flinkVersion: PUBLISHED_FLINK_VERSIONS[PUBLISHED_FLINK_VERSIONS.length - 1], | ||
}; | ||
|
||
export function flinkRunner(runnerOptions: Object = {}): Runner { | ||
return new (class extends Runner { | ||
async runPipeline( | ||
pipeline: Pipeline, | ||
options: Object = {} | ||
): Promise<PipelineResult> { | ||
const allOptions = { | ||
...defaultOptions, | ||
...runnerOptions, | ||
...options, | ||
} as any; | ||
if ( | ||
!allOptions.environmentType && | ||
MAGIC_HOST_NAMES.includes(allOptions.flinkMaster) | ||
) { | ||
allOptions.environmentType = "LOOPBACK"; | ||
} | ||
if (!allOptions.artifactsDir) { | ||
allOptions.artifactsDir = fs.mkdtempSync( | ||
path.join(os.tmpdir(), "flinkArtifactsDir") | ||
); | ||
} | ||
|
||
const jobServerJar = | ||
allOptions.flinkJobServerJar || | ||
(await JavaJarService.cachedJar( | ||
JavaJarService.gradleToJar( | ||
`runners:flink:${allOptions.flinkVersion}:job-server:shadowJar` | ||
) | ||
)); | ||
const jobServer = new JavaJarService(jobServerJar, [ | ||
"--flink-master", | ||
allOptions.flinkMaster, | ||
"--artifacts-dir", | ||
allOptions.artifactsDir, | ||
"--job-port", | ||
"{{PORT}}", | ||
"--artifact-port", | ||
"0", | ||
"--expansion-port", | ||
"0", | ||
]); | ||
|
||
return new PortableRunner(allOptions, jobServer).runPipeline(pipeline); | ||
} | ||
})(); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions that don't need action:
package-lock.json
file solves the problem that arises from dependency upgrades only if the upgrades are within our bounds of expectations.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I though the trend in node was to have lots of tiny packages to share code (kind of like the unix philosophy for binaries) rather than re-invent everything. But maybe that's a statement of how things are, not how they should be :).
Yeah, we should re-consider strictness too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right in the principle of having shared tiny packages. Problem (as evidenced over the last decade) is that the scope of what is considered to be a module is arbitrarily small. Loads of troll modules exist that do nothing comprehensive and eventually add to operational toil (versions, lock files, security checks etc.).
I usually see the code of the module and determine if it doing "reasonable" work to add it as a dependency. There could also be a trade-off some times since enthusiastic module authors lean strongly towards "generalize everything" (as they should) which may not serve long term evolving needs. This usually leads me to adopt the generalized code and tweak it to our specific use case instead of depending on a generalized module.