Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: testing python-based impersonation #17644

Closed
wants to merge 56 commits into from

Conversation

kennknowles
Copy link
Member

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@kennknowles
Copy link
Member Author

Locally ./gradlew :sdks:python:test-suites:dataflow:py38:postCommitIT passed, so checking it is not a false signal since #17244 was not passing. I'll leave this here. I think there are refactors in that PR that I have not got integrated to this branch.

@kennknowles
Copy link
Member Author

Run Python 3.8 PostCommit

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #17644 (caa3662) into master (f30e4e5) will decrease coverage by 0.00%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##           master   #17644      +/-   ##
==========================================
- Coverage   73.95%   73.94%   -0.01%     
==========================================
  Files         693      693              
  Lines       91720    91745      +25     
==========================================
+ Hits        67832    67845      +13     
- Misses      22639    22651      +12     
  Partials     1249     1249              
Flag Coverage Δ
python 83.70% <70.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/io/gcp/bigquery_tools.py 83.15% <ø> (ø)
...ks/python/apache_beam/runners/interactive/utils.py 95.06% <ø> (ø)
..._beam/runners/portability/sdk_container_builder.py 37.93% <0.00%> (ø)
...apache_beam/runners/dataflow/internal/apiclient.py 77.39% <50.00%> (+0.03%) ⬆️
sdks/python/apache_beam/internal/gcp/auth.py 73.33% <61.53%> (-7.71%) ⬇️
sdks/python/apache_beam/io/gcp/gcsfilesystem.py 88.65% <82.35%> (+0.41%) ⬆️
sdks/python/apache_beam/io/gcp/gcsio.py 92.26% <100.00%> (ø)
...dks/python/apache_beam/options/pipeline_options.py 94.93% <100.00%> (+0.01%) ⬆️
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) ⬇️
...ache_beam/runners/dataflow/test_dataflow_runner.py 29.62% <0.00%> (-3.03%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f30e4e5...caa3662. Read the comment docs.

@tvalentyn
Copy link
Contributor

Run Python 3.8 PostCommit

@kennknowles
Copy link
Member Author

Interesting that it passed

@kennknowles
Copy link
Member Author

oh yea, we determined that it was because the tests were interacting via global state, so when i narrow it to just this test it passes

@kennknowles kennknowles deleted the impersonation-py branch January 4, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants