-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#21252] Enforce pubsub message publishing limits in the python SDK #17794
Conversation
Can one of the admins verify this patch? |
2 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #17794 +/- ##
==========================================
- Coverage 74.00% 73.96% -0.04%
==========================================
Files 695 696 +1
Lines 91898 92205 +307
==========================================
+ Hits 68013 68204 +191
- Misses 22639 22755 +116
Partials 1246 1246
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
5907d19
to
756a02f
Compare
R: @pabloem |
@pabloem Friendly ping |
LGTM and there's a rcommendation from lint: https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Commit/14277/console |
… SDK This improves visiblity as otherwise messages can become stuck publishing inside the dataflow runner. This also allows users to handle errors by catching them. Fixes issue apache#21252 for python sdk.
Thanks Pablo, PTAL. There are a couple failures that appear unrelated though Run Python PreCommit hasn't finished yet |
Run Python 3.8 PostCommit |
2 similar comments
Run Python 3.8 PostCommit |
Run Python 3.8 PostCommit |
Thanks for the test fix, sorry I wasn't able to get my virtualenv setup so I was having trouble running tests locally before pushing. |
Run Python 3.8 PostCommit |
1 similar comment
Run Python 3.8 PostCommit |
postcomm running: https://ci-beam.apache.org/job/beam_PostCommit_Python38_PR/526/ |
Run Portable_Python PreCommit |
1 similar comment
Run Portable_Python PreCommit |
thanks Sam! merging. LGTM |
…ssage publishing limits in the python SDK * [apache#21252] Enforce pubsub message publishing limits in the python SDK This improves visiblity as otherwise messages can become stuck publishing inside the dataflow runner. This also allows users to handle errors by catching them. Fixes issue apache#21252 for python sdk. * fixtest Co-authored-by: Pablo <[email protected]>
This improves visiblity as otherwise messages can become stuck publishing
inside runners such as dataflow that specialize pubsub publishing. This also allows users to handle errors by
catching them.
Fixes issue #21252
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.