Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Spark 3 job-server as default Spark job-server for PortableRunner #23751

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

mosche
Copy link
Member

@mosche mosche commented Oct 20, 2022

Use Spark 3 job-server as default Spark job-server for PortableRunner (addresses #23728).

This includes changing Spark runner option --spark_version to use Spark 3 as default.
Besides being deprecated, the Spark 2 runner is in a badly broken state and it's unlikely it's successfully used (#23568).


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #23751 (7669a0b) into master (3ab9507) will increase coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #23751      +/-   ##
==========================================
+ Coverage   73.17%   73.22%   +0.05%     
==========================================
  Files         720      720              
  Lines       96044    96279     +235     
==========================================
+ Hits        70278    70505     +227     
- Misses      24454    24462       +8     
  Partials     1312     1312              
Flag Coverage Δ
python 82.99% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dks/python/apache_beam/options/pipeline_options.py 94.45% <ø> (ø)
...on/apache_beam/runners/portability/spark_runner.py 67.34% <0.00%> (ø)
...m/runners/portability/spark_uber_jar_job_server.py 84.32% <0.00%> (ø)
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) ⬇️
sdks/python/apache_beam/ml/gcp/visionml_test_it.py 63.63% <0.00%> (-3.04%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 90.50% <0.00%> (-1.27%) ⬇️
sdks/python/apache_beam/coders/coders.py 87.48% <0.00%> (+0.12%) ⬆️
...hon/apache_beam/runners/worker/bundle_processor.py 93.67% <0.00%> (+0.12%) ⬆️
sdks/python/apache_beam/io/gcp/gcsio.py 94.25% <0.00%> (+1.99%) ⬆️
sdks/python/apache_beam/ml/gcp/visionml.py 95.23% <0.00%> (+2.64%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mosche mosche force-pushed the 23728_Spark3_portability branch from ddce021 to 7669a0b Compare October 20, 2022 13:16
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @ryanthompson591 for label python.
R: @damccorm for label go.
R: @damccorm for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@mosche
Copy link
Member Author

mosche commented Oct 21, 2022

Run Java PreCommit

@mosche
Copy link
Member Author

mosche commented Oct 21, 2022

Run Java_Examples_Dataflow PreCommit

@mosche
Copy link
Member Author

mosche commented Oct 21, 2022

Run Python PreCommit

@damccorm
Copy link
Contributor

Run Java_Examples_Dataflow PreCommit

@damccorm
Copy link
Contributor

Run Python_PVR_Flink PreCommit

@damccorm
Copy link
Contributor

Run Seed Job

@damccorm
Copy link
Contributor

Run Go Spark ValidatesRunner

@damccorm
Copy link
Contributor

Run Java Spark PortableValidatesRunner Batch

@damccorm
Copy link
Contributor

Run Python Spark ValidatesRunner

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mosche mosche merged commit f083b05 into apache:master Oct 24, 2022
@mosche mosche deleted the 23728_Spark3_portability branch October 24, 2022 07:18
@mosche
Copy link
Member Author

mosche commented Oct 24, 2022

Thanks @damccorm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants