-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Spark 3 job-server as default Spark job-server for PortableRunner #23751
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23751 +/- ##
==========================================
+ Coverage 73.17% 73.22% +0.05%
==========================================
Files 720 720
Lines 96044 96279 +235
==========================================
+ Hits 70278 70505 +227
- Misses 24454 24462 +8
Partials 1312 1312
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ddce021
to
7669a0b
Compare
Assigning reviewers. If you would like to opt out of this review, comment R: @ryanthompson591 for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Run Java PreCommit |
Run Java_Examples_Dataflow PreCommit |
Run Python PreCommit |
Run Java_Examples_Dataflow PreCommit |
Run Python_PVR_Flink PreCommit |
Run Seed Job |
Run Go Spark ValidatesRunner |
Run Java Spark PortableValidatesRunner Batch |
Run Python Spark ValidatesRunner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @damccorm |
Use Spark 3 job-server as default Spark job-server for PortableRunner (addresses #23728).
This includes changing Spark runner option
--spark_version
to use Spark3
as default.Besides being deprecated, the Spark 2 runner is in a badly broken state and it's unlikely it's successfully used (#23568).
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.