[Go] Ensure iterated and emitted types are registered. #23890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #23890 +/- ##
==========================================
- Coverage 73.84% 73.30% -0.55%
==========================================
Files 707 720 +13
Lines 95746 96059 +313
==========================================
- Hits 70708 70414 -294
- Misses 23721 24329 +608
+ Partials 1317 1316 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @riteshghorse for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
capthiron
reviewed
Oct 29, 2022
| @@ -113,7 +123,9 @@ func Iter1[T any]() { | |||
| registerFunc := func(s exec.ReStream) exec.ReusableInput { | |||
| return &iter1[T]{s: s} | |||
| } | |||
| exec.RegisterInput(reflect.TypeOf(i).Elem(), registerFunc) | |||
| itT := reflect.TypeOf(i).Elem() | |||
There was a problem hiding this comment.
Hey @lostluck
I just started a test run with your changes applied with the bigtable io connector (#23411).
Unfortunately I still ran into the following error: reflect.Set: value of type struct { RowKey string; Ops []struct { Family string; Column string; Ts int64; Value []uint8 }; GroupKey string } is not assignable to type bigtableio.Mutation.
I played around with this implementation but wasn't able to make it work. My knowledge on the reflect package is somehow limited though.
|
That's very strange. That's what the additional registrations in this PR
should be handling.
That error means it didn't have the type registered and had to
synthetically generate it. In simple cases this satisfies Go's
Assignability rules but not so kuch for nested structs.
Is there more of a panic trace where that error comes from?
…On Sat, Oct 29, 2022, 8:06 AM capthiron ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In sdks/go/pkg/beam/register/iter.go
<#23890 (comment)>:
> @@ -113,7 +123,9 @@ func Iter1[T any]() {
registerFunc := func(s exec.ReStream) exec.ReusableInput {
return &iter1[T]{s: s}
}
- exec.RegisterInput(reflect.TypeOf(i).Elem(), registerFunc)
+ itT := reflect.TypeOf(i).Elem()
Hey @lostluck <https://github.com/lostluck>
I just started a test run with your changes applied with the bigtable io
connector (#23411 <#23411>).
Unfortunately I still ran into the following error: reflect.Set: value of
type struct { RowKey string; Ops []struct { Family string; Column string;
Ts int64; Value []uint8 }; GroupKey string } is not assignable to type
bigtableio.Mutation.
I played around with this implementation but wasn't able to make it work.
My knowledge on the reflect package is somehow limited though.
—
Reply to this email directly, view it on GitHub
<#23890 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKDOFPTGUI2RX7BWCNGSODWFU4QLANCNFSM6AAAAAARROGTG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Ah, I'm neglecting to strip the pointer from the type. Turns out "derived"
types like pointers and slices "don't exist" with how this registry was
built. Easy enough to fix (and test). Thanks for catching it!
…On Sat, Oct 29, 2022, 8:41 AM Robert Burke ***@***.***> wrote:
That's very strange. That's what the additional registrations in this PR
should be handling.
That error means it didn't have the type registered and had to
synthetically generate it. In simple cases this satisfies Go's
Assignability rules but not so kuch for nested structs.
Is there more of a panic trace where that error comes from?
On Sat, Oct 29, 2022, 8:06 AM capthiron ***@***.***> wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In sdks/go/pkg/beam/register/iter.go
> <#23890 (comment)>:
>
> > @@ -113,7 +123,9 @@ func Iter1[T any]() {
> registerFunc := func(s exec.ReStream) exec.ReusableInput {
> return &iter1[T]{s: s}
> }
> - exec.RegisterInput(reflect.TypeOf(i).Elem(), registerFunc)
> + itT := reflect.TypeOf(i).Elem()
>
> Hey @lostluck <https://github.com/lostluck>
> I just started a test run with your changes applied with the bigtable io
> connector (#23411 <#23411>).
> Unfortunately I still ran into the following error: reflect.Set: value
> of type struct { RowKey string; Ops []struct { Family string; Column
> string; Ts int64; Value []uint8 }; GroupKey string } is not assignable to
> type bigtableio.Mutation.
> I played around with this implementation but wasn't able to make it work.
> My knowledge on the reflect package is somehow limited though.
>
> —
> Reply to this email directly, view it on GitHub
> <#23890 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ADKDOFPTGUI2RX7BWCNGSODWFU4QLANCNFSM6AAAAAARROGTG4>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
|
RFAL |
capthiron
added a commit
to capthiron/beam
that referenced
this pull request
Nov 1, 2022
- bugfix apache#23890 will ensure that register.Iter1 will implicitly register bigtableio.Mutation
riteshghorse
approved these changes
Nov 1, 2022
|
Run Go PostCommit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23889
Resolves an issue with a pattern for transform package authors where they receive a given type from users, where that received type wouldn't be registered, leading to potential issues at authoring and testing time.
Transforms registered with
registerwon't have types in their emitters or iterators registered due to complexities WRT generics. Instead, also ensure those types are registered with the Iter and Emitter* methods.Also moves the iterator and emitter tests to co-aligned files, to make them easier to find.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.